Todos project / Vera Sjunnesson#445
Open
Vera-Sjunnesson wants to merge 32 commits intoTechnigo:masterfrom
Open
Todos project / Vera Sjunnesson#445Vera-Sjunnesson wants to merge 32 commits intoTechnigo:masterfrom
Vera-Sjunnesson wants to merge 32 commits intoTechnigo:masterfrom
Conversation
added 22 commits
April 17, 2023 19:59
JohLeo
approved these changes
May 1, 2023
JohLeo
left a comment
JohLeo
left a comment
There was a problem hiding this comment.
Impressive work as always with the limited time you've had. Overall well-structured and readable code. A very good design added to that, job very well done Vera!!!
Comment on lines
+8
to
+12
| <WaveAnimation /> | ||
| <HeaderWrapper> | ||
| <HeaderText>TODO TODO TODO TODO TODO TODO TODO TODO TODO</HeaderText> | ||
| </HeaderWrapper> | ||
| </> |
There was a problem hiding this comment.
Such a nice and creative header, well done!
Comment on lines
+95
to
+98
| <ProjectWrapper> | ||
| {Array.isArray(lists) && lists.map((list, listIndex) => ( | ||
| <> | ||
| <ProjectHeader key={list.name} style={{ background:`${colorsArray[a, listIndex]}`}}> |
There was a problem hiding this comment.
A tip is to use key prop on the outermost component: In the Array.map() method, the key prop is currently being set on the ProjectHeader component. It is recommended to set it on the outermost div or fragment component instead. :)
| display: flex; | ||
| margin:0; | ||
| padding:0; | ||
| } No newline at end of file |
There was a problem hiding this comment.
Neat structure and nice work with the global styling!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://to-do-project-vera.netlify.app/