Skip to content

Ylvas ToDo-project Week 11#446

Open
YlvaKarlsson wants to merge 28 commits intoTechnigo:masterfrom
YlvaKarlsson:master
Open

Ylvas ToDo-project Week 11#446
YlvaKarlsson wants to merge 28 commits intoTechnigo:masterfrom
YlvaKarlsson:master

Conversation

@YlvaKarlsson
Copy link
Copy Markdown

This was a fun week - finally!
Happy to be able to have a working project :D

Copy link
Copy Markdown

@majazimnoch majazimnoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job Ylva, I'm impressed by how ambitious your approach to this project was! Everything looks great, the date is in a nice format, a lot of extra functions and functionality. Maybe you can try later to make the categories work, then I will be happy to learn how you made it work!

Comment thread code/src/App.js Outdated
Comment on lines +20 to +21

// ctrl + c inside the terminal to stop the liveServer No newline at end of file
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice that you write such comments but I think our final code should be without comments, however, I strongly advise you to make a separate google sheet - docs - where you put all your coding notes ;)

Comment thread code/src/redux/reducers/todos.js Outdated
Comment on lines +6 to +19
id: '189438fdjhrjejioe9845',
name: 'ToDo1',
isNew: false
},
{
id: '189438fdjhrjejioe9846',
name: 'ToDo2',
isNew: false
},
{
id: '189438fdjhrjejioe9847',
name: 'ToDo3',
isNew: false
}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can also start your list with no to-dos by making an empty array, like:

const initialState = {
  items: [ ]
}

Comment thread code/public/index.html
Comment on lines +8 to 12
Favicon provided free from Icons8 - here you can reed more about the usage of this in your own projects
https://icons8.com/license
Notice the use of %PUBLIC_URL% in the tags above.
It will be replaced with the URL of the `public` folder during the build.
Only files inside the `public` folder can be referenced from the HTML.
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is such a great thing to add credits in the html, commented out.

Comment thread code/src/components/AddToDo.js Outdated
Comment on lines +8 to +33
const NewToDo = styled.form`
line-height: 0.5rem;
padding-bottom: 0.8rem;
`;

const Input = styled.input`
background: #a83256;
border: none;
padding: 8px;
font-size: 18px;
font-family: 'Baloo 2', cursive;
border-bottom: 2px dashed;
:focus {
outline: none;
}
`;

const AddButton = styled.button`
font-family: 'Baloo 2', cursive;
font-size: 18px;
border: none;
background: transparent;
cursor: pointer;
`;

export const AddToDo = () => {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice that you like using styled-components! if you like different ways of styling you can read more about Sass or tailwind css :) Maybe you can also try to switch to rems, ems instead of px.

Comment thread code/src/index.css Outdated

body {
background: rgb(51,102,255);
background: linear-gradient(180deg, rgba(51,102,255,1) 0%, rgba(255,0,255,1) 100%);
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice styling with gradient! ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants