Skip to content

Tess Aquilon - Project Todos#454

Open
codeandjazz wants to merge 35 commits intoTechnigo:masterfrom
codeandjazz:master
Open

Tess Aquilon - Project Todos#454
codeandjazz wants to merge 35 commits intoTechnigo:masterfrom
codeandjazz:master

Conversation

@codeandjazz
Copy link
Copy Markdown

Copy link
Copy Markdown

@code-and-cats code-and-cats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very clean and nice site! I love the colors and the theme, super cute!!
The complete and delete buttons are intuitive and easy to understand. The code is clean and easy to read, although I think some comments here or there might be helpful for the future or for someone who didn't just do the exact same project 😅
The one thing I can see might improve it is that there seems to be some pictures left from earlier designs in the repo, maybe delete them?
Well done!

const onFormSubmit = (event) => {
event.preventDefault();
const newTodo = {
id: Date.now().toString(),
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice way of doing the unique id

Comment thread code/src/index.css Outdated
box-shadow: 0px 4px 8px rgba(0, 0, 0, 0.2);
}

ul {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice use of grid areas here

Comment thread code/src/components/AddTodo.js Outdated
required />
</label>
<div className="lazy-cat-main">
<Player
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the animation!

Comment thread code/src/index.css Outdated
text-align: start;
}

.lazy-cat-header {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interesting way of solving the moving of the animation between different screen sizes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants