feat(install-skill): add Kimi Code harness support - #65
Merged
Conversation
Add kimi-code to the install-skill harness list: installs the bundled SKILL.md into ~/.kimi/skills (Kimi Code CLI's brand-group user skills directory, highest priority per https://github.com/MoonshotAI/kimi-cli/blob/main/docs/en/customization/skills.md). Detection signals: ~/.kimi directory and kimi/kimi-cli on PATH. Aliases: kimi, kimi-code, kimi-cli, kimicode, kimi_cli.
… KIMI_CODE_HOME Kimi Code CLI's canonical repo is MoonshotAI/kimi-code: user-level skills live in $KIMI_CODE_HOME/skills (default ~/.kimi-code/skills), not kimi-cli's ~/.kimi/skills. Detection checks the kimi-code home dir (env-aware label) and the kimi binary on PATH. Serialize env-mutating kimi tests with a shared mutex to avoid a parallel-test race on KIMI_CODE_HOME.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
bsk install-skilldid not support Kimi Code CLI (MoonshotAI/kimi-code), so users of that harness had to copySKILL.mdmanually.What changes
New
kimi-codeharness inskill_install::harness:$KIMI_CODE_HOME/skills/browser-skill, defaulting to~/.kimi-code/skills/browser-skill— Kimi Code CLI's Kimi-specific user-level skills directory (per the official skills doc). TheKIMI_CODE_HOMEoverride is honored, same pattern asHERMES_HOMEfor the hermes harness.kimion PATH.kimi,kimi-code,kimi-cli,kimicode,kimi_cli.No other harness behaviour touched;
--all/--yes/interactive flows pick it up automatically through the existing detection logic.Notes:
KIMI_CODE_HOMEreads/writes would otherwise race).Tests
KIMI_CODE_HOMEoverride, cli/display names.cargo fmt --all,cargo clippy -p bsk --all-targets -- -D warnings: clean.cargo test -p bsk --lib skill_install: all pass except the pre-existing, environment-dependentsync_continues_on_partial_error(fails identically on cleanmainin this environment).