Skip to content

Fix ACK timer to use local max_ack_delay - #527

Open
SC123667 wants to merge 1 commit into
Tencent:developfrom
SC123667:codex/fix-ack-delay-timer-499
Open

Fix ACK timer to use local max_ack_delay#527
SC123667 wants to merge 1 commit into
Tencent:developfrom
SC123667:codex/fix-ack-delay-timer-499

Conversation

@SC123667

Copy link
Copy Markdown

Summary

  • schedule delayed ACKs with the locally advertised max_ack_delay
  • add a regression test with intentionally different local and peer values

Root cause

try_schedule_ack_frame used peer_transport_params.max_ack_delay when scheduling an ACK sent by the local endpoint. The peer value describes how long the peer may delay its ACKs; the local ACK timer must follow local_transport_params.max_ack_delay.

Validation

  • cargo fmt --check
  • cargo test --verbose (559 unit tests and 1 doc test passed)
  • cargo clippy --all -- -D warnings
  • cargo clippy --all -F ffi -- -D warnings

Resolves #499

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: Incorrect use of peer_transport_params.max_ack_delay in ACK scheduling

1 participant