Propagate TLS alert error codes - #528
Open
SC123667 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CRYPTO_ERRORcodes in the reserved0x100..=0x1ffrangeCONNECTION_CLOSERoot cause
BoringSSL recorded the specific
0x100 + alertcode inTlsSessionData, butConnection::process_tls_sessionnever copied it intolocal_error. The generic receive error path then closed the connection withTlsFail::to_wire(), which fell back toNO_ERROR(0x0).Testing
cargo fmt --all -- --checkcargo clippy --all -- -D warningscargo clippy --all -F ffi -- -D warningscargo test --verbose(558 unit tests and 1 doc test)cargo build --all -F ffi --verbosecargo test --no-default-features(388 unit tests and 1 doc test)cargo test --no-default-features -F ffi,qlog,h3(558 unit tests and 1 doc test)typos -c ./typos.tomlResolve #243