fix(cubemaster): clean job rows after snapshot delete

[xiaojunxiang2023]

Summary

Fixes a bug where deleted snapshots still appeared in template list APIs until a second delete.

After the first DELETE /templates/{snapshotID}:

• Single-snapshot lookup correctly returned not found
• GET /templates and cubemastercli tpl ls still listed the deleted snapshot
• A second delete was required to remove it from the list

Root cause

Snapshot delete (runSnapshotDeleteJob) removed template_definition metadata but did not remove related template_image_job rows.

ListTemplates appends orphan job records when no definition exists:

for _, job := range jobs {
    if _, ok := seen[job.TemplateID]; ok {
        continue
    }
    out = append(out, templateInfoFromJob(&job))
}

So the deleted snapshot was resurrected in list responses via job fallback entries.

On the second delete, has_snapshot returned false (definition gone, job fallback has no Kind), routing the request through template delete (cleanupTemplateJobs) instead of snapshot delete.

Fix

• Call cleanupTemplateJobs after successful snapshot metadata cleanup, matching template delete behavior
• Return terminal READY job info from executeSnapshotDeleteJob without re-querying job rows that were just deleted

Deploy And Verify

[cubesandboxbot]

Review: PR 559

[fslongjin]

This test is risky for CI under the default Go compiler settings. deleteSnapshotMetadataOnly is just a tiny wrapper, so the compiler may inline it; when that happens, gomonkey.ApplyFunc(deleteSnapshotMetadataOnly, ...) does not intercept the call and the test still reaches the real cleanupTemplateMetadata. Since the test sets store.db to an empty &gorm.DB{}, that real DB path can panic.

I can reproduce this locally: go test ./pkg/templatecenter panics in TestRunSnapshotDeleteJobCleansTemplateJobs, while go test -gcflags=all=-l ./pkg/templatecenter passes after disabling inlining. Consider avoiding a patch on this tiny wrapper, for example by introducing a replaceable function variable or by using a real test DB to verify the job cleanup behavior.