fix(gateway): isolate Hermes memory by user#231
Open
YOMXXX wants to merge 1 commit into
Open
Conversation
Signed-off-by: 李冠辰 <liguanchen@xiaomi.com>
Collaborator
|
Thanks for the contribution! The PR is well-structured and the code quality is solid 👍 Regarding user-based memory isolation — multi-user management will be handled internally as part of our upcoming roadmap with a unified solution. That said, your implementation is well-thought-out, and we'll take some of the ideas and patterns from it as a reference for our internal work. Appreciate your understanding and continued contributions! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
user_idfor Hermes requestsuser_idthrough Hermes search/seed client APIs and memory tool callsVerification
npm test -- --runnpm run build:pluginpython3 -m compileall -q hermes-plugin/memory/memory_tencentdbnpx vitest run src/gateway --runNote:
npm run test:cc-plugin -- --runis not available in this package.json (Missing script: test:cc-plugin).