Skip to content

Added nosql and dynamo plugins#429

Open
ghost wants to merge 1 commit intoTeradata:masterfrom
Zoomdata:base-nosql
Open

Added nosql and dynamo plugins#429
ghost wants to merge 1 commit intoTeradata:masterfrom
Zoomdata:base-nosql

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Nov 17, 2016

added nosql counterpart to base-jdbc submodule
added dynamodb plugin

<version>3.4</version>
</dependency>

<!-- for testing -->
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not necessary comment.

import static java.util.Objects.requireNonNull;

/**
* Created by amehta on 6/13/16.
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove that.

import java.util.Properties;

/**
* Created by amehta on 6/13/16.
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

@maciejgrzybek
Copy link
Copy Markdown

Seems like there are some code style failures. Can you reformat the code using code style defined in https://github.com/airlift/codestyle ?

@akshatnair
Copy link
Copy Markdown

Please add Apache license header on all the new files

@cawallin
Copy link
Copy Markdown

@sclinebacker84 -- our apologies for not getting back to you sooner, but if you want to get this PR into upstream master (prestodb/presto), please submit a pull request there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants