Add support for Azure Blob#641
Conversation
petroav
left a comment
petroav
left a comment
There was a problem hiding this comment.
Minor comments only.
Can you change the commit message of e913b4a to Update the version of hadoop-apache2.
Can you squash 415b1f7 and db37ed8? The feature and its unit test should be in a single commit. Also can you re-phrase the commit message to Add configuration variables for authenticating to Azure Blob.
There was a problem hiding this comment.
You're cutting the S3 'paragraph' into two by placing the two lines here. I suggest starting another code 'paragraph' just for blob either after or before the S3 'paragraph'.
There was a problem hiding this comment.
The parentheses around each comparison are unnecessary. Equality comparisons have higher precedence that logical AND.
There was a problem hiding this comment.
No need to create a separate variable, just inline it where it is used like you do elsewhere.
cawallin
left a comment
cawallin
left a comment
There was a problem hiding this comment.
looks good % a small addition to the test
3 participants
No description provided.