removed all weapons from starting inventory and made weapons purchasable#249
Open
removed all weapons from starting inventory and made weapons purchasable#249
Conversation
this PR removes all weapons from starting inventory therefore making weapons to be purchased
this commit makes the weapons purchasable
jdrueckert
reviewed
Nov 17, 2021
Member
jdrueckert
left a comment
There was a problem hiding this comment.
Can you please add some information to the PR description detailing why you chose the respective values for the different items? For instance, why does the waraxe cost twice as much as the sword or spear?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #248
This PR removes all weapons from starting inventory. It makes weapons purchaseable and attempts to balance them a bit better.
We do have different dimensions along which we can assess the (combat) value of a weapon:
Time to kill is
ceil(playerMaxHealth / damage) * cooldownwithplayerMaxHealth = 100.Starting money for players is 100.
Melee weapons - sword, axe (, staff, spear)
Ranged, ammo-less weapons - staff (fireball)
Ranged, ammo-requiring weapons - Crossbow (arrows)
Ranged, pick-up weapons - Spear (throw)