Add static Vercel landing page, codespell, and unify CI via ./scripts/check.sh#11
Open
Huynhthuongg wants to merge 4 commits into
Open
Add static Vercel landing page, codespell, and unify CI via ./scripts/check.sh#11Huynhthuongg wants to merge 4 commits into
./scripts/check.sh#11Huynhthuongg wants to merge 4 commits into
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
📝 WalkthroughWalkthroughPR thêm mới một trang landing tĩnh cho Vercel bao gồm HTML, CSS, và JavaScript với animationcó mục đích. Quy trình kiểm tra phát triển được cấu trúc lại thành một script tập trung với xác thực phụ thuộc. Cấu hình Vercel cung cấp routing và các header bảo mật. Tài liệu hướng dẫn cách triển khai và quy trình phát triển. ChangesTrang Landing Vercel & Cơ Sở Hạ Tầng Triển Khai
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 phút Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
✨ Simplify code
Warning Review ran into problems🔥 ProblemsLinked repositories: Your configuration references 1 linked repositories, but your current plan allows 0. Analyzed ``, skipped Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Kilo Code Review could not run — your account is out of credits. Add credits or switch to a free model to enable reviews on this change. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 6
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@public/app.js`:
- Around line 1-15: The code assumes IntersectionObserver exists so new
IntersectionObserver(...) will throw in unsupported browsers and .reveal
elements stay hidden; guard the creation and use of observer by checking if
'IntersectionObserver' in window and if missing, immediately add the 'visible'
class to all elements matching '.reveal' (or remove the 'js' hiding class)
instead of creating the observer, otherwise proceed to create observer and call
observer.observe as currently done; refer to
document.documentElement.classList.add, the IntersectionObserver instantiation,
observer.observe and querySelectorAll('.reveal') to locate where to add the
feature-detection fallback.
In `@public/styles.css`:
- Around line 30-31: Add an accessible keyboard focus style using :focus-visible
for interactive elements that currently only have :hover; update the existing
anchor selector (a) and any button-like selectors (button, a[href], .btn,
.icon-button, input[type="button"/"submit"]) to include a :focus-visible rule
that applies a clear focus ring (e.g., visible outline or box-shadow),
outline-offset and respects border-radius so focused elements are easily
discoverable; ensure you do this alongside the existing text-decoration:none for
a so keyboard users still get a visible indicator rather than relying on
hover-only styles.
In `@pyproject.toml`:
- Around line 52-54: The [tool.codespell] configuration may be ignored on Python
3.10 because tomli is required to parse pyproject.toml on Python < 3.11; add
tomli as a conditional dependency for older Python versions (e.g., tomli;
python_version < "3.11") or ensure codespell is installed in a way that pulls
tomli so that the skip and ignore-words-list ("thi") settings are respected
during runs on Python 3.10.
In `@README.md`:
- Around line 73-83: Update the README description to accurately reflect the
contents of vercel.json: state that vercel.json configures URL cleanup options
(cleanUrls, trailingSlash) and security headers rather than custom routing
rules; mention that any custom routing would require additional
rewrites/redirects entries which are not present in vercel.json; reference the
vercel.json file and the README section about the Vercel landing page so the
reader knows where to look.
- Around line 3-12: The README contains an internal link
href="public/index.html" used by the "Preview the landing page" anchor which
won’t render correctly on GitHub; update the "Preview the landing page" link to
point to the actual live deployment URL (e.g., your Vercel app) or, if no
deployment exists, replace it with a GitHub Pages URL or remove the anchor and
leave only the "Deploy on Vercel" link—edit the <a
href="public/index.html">Preview the landing page</a> anchor in README.md
accordingly so the anchor text still reads "Preview the landing page" but its
href points to a publicly accessible deployment.
In `@vercel.json`:
- Around line 4-13: Update the existing "headers" array entry for the route with
"source": "/(.*)" to include the missing security headers: add "X-Frame-Options"
(e.g., "DENY") or a frame-ancestors directive inside a Content-Security-Policy,
add a strict Content-Security-Policy value that restricts resources to self and
the allowed Google Fonts origins, and add "Strict-Transport-Security" (e.g.,
max-age=31536000; includeSubDomains; preload); modify the headers list in the
same object containing "X-Content-Type-Options" etc. so all security headers are
present for that route.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: c8ed8ad5-7076-4b99-b19f-9b0ba0fcdcf6
⛔ Files ignored due to path filters (3)
public/badges/fastapi.svgis excluded by!**/*.svgpublic/badges/termux.svgis excluded by!**/*.svgpublic/badges/vercel.svgis excluded by!**/*.svg
📒 Files selected for processing (8)
.github/workflows/ci.ymlREADME.mdpublic/app.jspublic/index.htmlpublic/styles.csspyproject.tomlscripts/check.shvercel.json
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9e9ca0286d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
1 issue found across 9 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="vercel.json">
<violation number="1" location="vercel.json:26">
P1: Rewrite destinations incorrectly use `/public/` prefix — Vercel serves `public/` content at root URL paths (e.g., `/index.html`, not `/public/index.html`). Combined with `cleanUrls: true`, the `.html` extension in the destination also violates Vercel's documented requirement. These rewrites are both unnecessary and potentially harmful (could cause 404s on routes that should work).</violation>
</file>
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
Contributor
There was a problem hiding this comment.
1 issue found across 5 files (changes from recent commits).
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
Huynhthuongg
added
bug
…e-fixes-6qh4yq Reduce landing page PR merge scope
…e-fixes Merge pull request #12 from Huynhthuongg/codex/review-code-and-propose-fixes-6qh4yq Reduce landing page PR merge scope
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9265cdd901
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This was
linked to
issues
Jun 19, 2026
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
public/includingindex.html,styles.css,app.js, and animated SVG badges, and addvercel.jsonfor routing and security headers..github/workflows/ci.ymlto run./scripts/check.shinstead of individualruff/pyteststeps.scripts/check.shto verify required dev commands/modules, fail early with guidance, and runruff,codespell, andpytest -qin sequence.pyproject.tomlto addcodespellto thedevextras and include a[tool.codespell]config, and updateREADME.mdto document the landing page and use of./scripts/check.sh.Testing
./scripts/check.sh, which verifies dev dependencies then executesruff,codespell, andpytest -q, and the script completed successfully../scripts/check.shacross Python versions3.10,3.11, and3.12in GitHub Actions (matrix), ensuring consistent automated checks.Codex Task
Summary by cubic
Adds a Vercel-ready static landing page and configures
codespell. Ships a polished static site with security headers and simple rewrites, plus README deploy steps.public/(index.html,styles.css,app.js) with animated SVG badges and scroll-reveal.vercel.jsonwith clean URLs, security headers, and routes for/,/styles.css,/app.js, and/badges/*.README.mdupdated with badges, page preview, and Vercel deploy instructions.pyproject.tomladds[tool.codespell](skip caches; ignore "thi").Written for commit 9265cdd. Summary will update on new commits.