Merge pull request #30 from Huynhthuongg/main Dev#36
Open
Huynhthuongg wants to merge 36 commits into
Open
Conversation
…-fixes Add dry-run & safe output_dir checks, serve dashboard template, bump version, and expand CI matrix
…e-fixes-at7thi Unify CI checks behind `./scripts/check.sh`, add codespell and dependency validation
Merge pull request #10 from Huynhthuongg/codex/review-code-and-propose-fixes-at7thi Unify CI checks behind `./scripts/check.sh`, add codespell and dependency validation
Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>
Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>
Update README.md Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>
Merge pull request #25 from Huynhthuongg/main
Revert "Merge pull request #25 from Huynhthuongg/main"
- Remove httpx2>=2.3,<3.0 from pyproject.toml (line 24) - Remove httpx2 from check.sh module validation (line 11) - Keep httpx>=0.28,<1.0 which is the correct package Fixes dependency resolution errors in CI/CD and local setup.
fix: remove non-existent httpx2 dependency
- Add Weather Dashboard with real-time weather fetching - Integrate OpenWeatherMap API for global weather data - Implement responsive HTML5 UI with modern design - Add city search functionality with autocomplete - Add save/favorite cities with SQLite database - Include comprehensive weather details (temperature, humidity, wind, pressure, sunrise/sunset) - Add security headers and error handling - Responsive design for mobile, tablet, and desktop - FastAPI with async/await pattern - Complete API documentation Files added: - weather_dashboard/config.py - Configuration management - weather_dashboard/models.py - Data models (WeatherData, SavedCity, etc.) - weather_dashboard/weather_service.py - OpenWeatherMap API integration - weather_dashboard/database.py - SQLite database operations - weather_dashboard/app.py - FastAPI application and routes - weather_dashboard/templates.py - Beautiful HTML dashboard - weather_dashboard/__init__.py - Package initialization - config/weather.env.example - Environment configuration example - README_WEATHER.md - Complete documentation
feat: add weather dashboard application
Merge pull request #30 from Huynhthuongg/main
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Huynhthuongg
added
bug
### Motivation - Serve the FastAPI dashboard from Vercel and route all requests to the Python serverless function so the site does not return `404: NOT_FOUND` when deployed. ### Description - Add a Vercel routing config via `vercel.json` to forward all requests to `api/index.py`. - Add `api/index.py` which exposes the FastAPI `app` by importing `universal_compiler_agent.server` and adjusting `sys.path` for the `app` package. - Add `requirements.txt` and document Vercel deployment in `README.md` with instructions to run `vercel` from the project root. - Update `pyproject.toml` to include an additional optional dev dependency and add a new test `tests/test_vercel.py` that verifies the Vercel config and the serverless entrypoint respond correctly. ### Testing - Ran `pytest tests/test_vercel.py` and the new tests passed, confirming that `vercel.json` contains the expected `builds` and `routes` and that the `api/index.py` entrypoint exposes a working FastAPI `app` (status `200`). ------ [Codex Task](https://chatgpt.com/codex/cloud/tasks/task_e_6a2fa2d9a5c4832c9c9468a962d09acf)
Implemented Vercel Web Analytics for the Universal Project Compiler Agent ## Summary Successfully configured Vercel Web Analytics for this Python FastAPI application by adding the official Vercel Analytics CDN script to the HTML template. ## Changes Made ### Modified Files: - `app/universal_compiler_agent/templates.py` - Added Vercel Analytics script tag using the CDN approach - Script placed before closing `</body>` tag as per official documentation - Used deferred loading to avoid blocking page render ## Implementation Details ### Approach Selected: Since this is a Python FastAPI application serving vanilla HTML/JavaScript (not a Node.js project), I used the **CDN script injection method** as recommended by the official Vercel documentation. ### Why This Approach: 1. **No npm/package manager required**: This is a Python project without Node.js dependencies 2. **Framework-appropriate**: The vanilla HTML/JavaScript template matches the CDN script approach 3. **Latest documentation followed**: Fetched current instructions from https://vercel.com/docs/analytics/quickstart 4. **Zero build changes**: No additional build steps or dependencies needed ### Script Added: ```html <script defer src="https://cdn.vercel-insights.com/v1/script.js"></script> ``` The script tag: - Uses `defer` attribute for non-blocking load - Points to the official Vercel CDN - Automatically tracks page views once deployed to Vercel - Requires Web Analytics to be enabled in the Vercel dashboard ## Verification Steps Completed ✓ Python syntax validation passed ✓ HTML structure integrity verified ✓ Analytics script correctly positioned before closing body tag ✓ Template imports successfully without errors ✓ All existing Python modules validate correctly ## Next Steps for Deployment To complete the Web Analytics setup: 1. **Enable Analytics in Vercel Dashboard**: - Go to your project settings on Vercel - Navigate to the Analytics section - Enable Web Analytics 2. **Deploy the changes**: ```bash git push origin main vercel deploy --prod ``` 3. **Verify tracking**: - Visit your deployed site - Open browser DevTools → Network tab - Look for requests to Vercel analytics endpoints - Analytics data will appear in the Vercel dashboard ## Notes - No package.json or lock files needed (Python project) - The script loads asynchronously and won't affect page performance - Analytics will only be active when deployed to Vercel infrastructure - Local development won't trigger analytics events ## Documentation References - Vercel Analytics Quickstart: https://vercel.com/docs/analytics/quickstart - Script injection method: https://vercel.com/docs/analytics/package Co-authored-by: Vercel <vercel[bot]@users.noreply.github.com>
Implemented Vercel Web Analytics for the Universal Project Compiler Agent ## Summary Successfully configured Vercel Web Analytics for this Python FastAPI application by adding the official Vercel Analytics CDN script to the HTML template. ## Changes Made ### Modified Files: - `app/universal_compiler_agent/templates.py` - Added Vercel Analytics script tag using the CDN approach - Script placed before closing `</body>` tag as per official documentation - Used deferred loading to avoid blocking page render ## Implementation Details ### Approach Selected: Since this is a Python FastAPI application serving vanilla HTML/JavaScript (not a Node.js project), I used the **CDN script injection method** as recommended by the official Vercel documentation. ### Why This Approach: 1. **No npm/package manager required**: This is a Python project without Node.js dependencies 2. **Framework-appropriate**: The vanilla HTML/JavaScript template matches the CDN script approach 3. **Latest documentation followed**: Fetched current instructions from https://vercel.com/docs/analytics/quickstart 4. **Zero build changes**: No additional build steps or dependencies needed ### Script Added: ```html <script defer src="https://cdn.vercel-insights.com/v1/script.js"></script> ``` The script tag: - Uses `defer` attribute for non-blocking load - Points to the official Vercel CDN - Automatically tracks page views once deployed to Vercel - Requires Web Analytics to be enabled in the Vercel dashboard ## Verification Steps Completed ✓ Python syntax validation passed ✓ HTML structure integrity verified ✓ Analytics script correctly positioned before closing body tag ✓ Template imports successfully without errors ✓ All existing Python modules validate correctly ## Next Steps for Deployment To complete the Web Analytics setup: 1. **Enable Analytics in Vercel Dashboard**: - Go to your project settings on Vercel - Navigate to the Analytics section - Enable Web Analytics 2. **Deploy the changes**: ```bash git push origin main vercel deploy --prod ``` 3. **Verify tracking**: - Visit your deployed site - Open browser DevTools → Network tab - Look for requests to Vercel analytics endpoints - Analytics data will appear in the Vercel dashboard ## Notes - No package.json or lock files needed (Python project) - The script loads asynchronously and won't affect page performance - Analytics will only be active when deployed to Vercel infrastructure - Local development won't trigger analytics events ## Documentation References - Vercel Analytics Quickstart: https://vercel.com/docs/analytics/quickstart - Script injection method: https://vercel.com/docs/analytics/package --- [View Project](https://vercel.com/agent-rkix-3-s-projects/agents-md-fudg) · [Web Analytics](https://vercel.com/agent-rkix-3-s-projects/agents-md-fudg/analytics) Created by **AGENT-RKIX3 (nvht25052002-2777)** with [Vercel Agent](https://vercel.com/docs/agent)
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Adds a Weather Dashboard app and hardens the compiler agent with a safer CLI/server (dry‑run and safe output_dir), improved CI, and refreshed docs. Bumps the agent to v0.1.1 and aligns the web dashboard with public /plan and /compile routes.
New Features
weather_dashboard:FastAPIapp with OpenWeatherMap integration, city search, favorites via SQLite, responsive HTML UI, and example config (config/weather.env.example).upca compile --dry-run, safe relative--output-dirvalidation in CLI and API, serve maintained index template, version set to 0.1.1.Refactors
./scripts/check.sh; addedcodespell; run lint/tests across Python 3.10–3.12; updatedpyproject.toml(dev deps:httpx,codespell) and package discovery./planand/compile; added tests for route alignment and path safety.Written for commit e97ee8b. Summary will update on new commits.