Skip to content

Merge pull request #28 from Huynhthuongg/AGENTS fix: remove non-existent httpx2 dependency#37

Open
Huynhthuongg wants to merge 22 commits into
codex/review-code-and-propose-fixes-6qh4yqfrom
feature/weather-dashboard-enhanced
Open

Merge pull request #28 from Huynhthuongg/AGENTS fix: remove non-existent httpx2 dependency#37
Huynhthuongg wants to merge 22 commits into
codex/review-code-and-propose-fixes-6qh4yqfrom
feature/weather-dashboard-enhanced

Conversation

@Huynhthuongg

@Huynhthuongg Huynhthuongg commented Jun 10, 2026

Copy link
Copy Markdown
Member

Summary by cubic

Remove non-existent httpx2 dev dependency, add codespell, and unify CI checks under ./scripts/check.sh to fix CI failures and streamline local setup.

  • Dependencies

    • Remove httpx2 from dev extras.
    • Bump httpx to >=0.28,<1.0.
    • Add codespell[toml] and configure [tool.codespell] (skip common dirs, ignore “thi”).
    • Correct setuptools package-dir mapping to {"": "app"}.
  • Refactors

    • Replace separate ruff/pytest CI steps with ./scripts/check.sh.
    • check.sh validates ruff, codespell, pytest, and httpx, then runs ruff, codespell, and pytest.

Written for commit 154aaeb. Summary will update on new commits.

Review in cubic

Huynhthuongg and others added 17 commits June 3, 2026 07:44
…e-fixes-at7thi

Unify CI checks behind `./scripts/check.sh`, add codespell and dependency validation
Merge pull request #10 from Huynhthuongg/codex/review-code-and-propose-fixes-at7thi

Unify CI checks behind `./scripts/check.sh`, add codespell and dependency validation
…alytics-w-ufsgkw

Merge pull request #14 from Huynhthuongg/main

Merge pull request #10 from Huynhthuongg/codex/review-code-and-propose-fixes-at7thi

Unify CI checks behind `./scripts/check.sh`, add codespell and dependency validation
Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>
Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>
Update README.md

Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>
Merge pull request #25 from Huynhthuongg/main
Revert "Merge pull request #25 from Huynhthuongg/main"
- Remove httpx2>=2.3,<3.0 from pyproject.toml (line 24)
- Remove httpx2 from check.sh module validation (line 11)
- Keep httpx>=0.28,<1.0 which is the correct package

Fixes dependency resolution errors in CI/CD and local setup.
fix: remove non-existent httpx2 dependency
- Add Weather Dashboard with real-time weather fetching
- Integrate OpenWeatherMap API for global weather data
- Implement responsive HTML5 UI with modern design
- Add city search functionality with autocomplete
- Add save/favorite cities with SQLite database
- Include comprehensive weather details (temperature, humidity, wind, pressure, sunrise/sunset)
- Add security headers and error handling
- Responsive design for mobile, tablet, and desktop
- FastAPI with async/await pattern
- Complete API documentation

Files added:
- weather_dashboard/config.py - Configuration management
- weather_dashboard/models.py - Data models (WeatherData, SavedCity, etc.)
- weather_dashboard/weather_service.py - OpenWeatherMap API integration
- weather_dashboard/database.py - SQLite database operations
- weather_dashboard/app.py - FastAPI application and routes
- weather_dashboard/templates.py - Beautiful HTML dashboard
- weather_dashboard/__init__.py - Package initialization
- config/weather.env.example - Environment configuration example
- README_WEATHER.md - Complete documentation
feat: add weather dashboard application
Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>
@qodo-code-review

Copy link
Copy Markdown

Qodo reviews are paused for this user.

Troubleshooting steps vary by plan Learn more →

On a Teams plan?
Reviews resume once this user has a paid seat and their Git account is linked in Qodo.
Link Git account →

Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center?
These require an Enterprise plan - Contact us
Contact us →

@vercel

vercel Bot commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
agents-md Error Error Jun 10, 2026 1:59pm

@coderabbitai

coderabbitai Bot commented Jun 10, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 9041e82a-dcdb-465b-b98c-4f9f3636f9c5

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/weather-dashboard-enhanced
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch feature/weather-dashboard-enhanced
  • 🛠️ Aethon

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@kilo-code-bot

kilo-code-bot Bot commented Jun 10, 2026

Copy link
Copy Markdown

Kilo Code Review could not run — your account is out of credits.

Add credits or switch to a free model to enable reviews on this change.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 154aaeb3f1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/workflows/ci.yml
Comment thread pyproject.toml Outdated
Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com> (#39)
Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com> (#39) (#47)
Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com> (#39) (#47) (#72)
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com> (#39) (#47) (#72) (#73)
Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com> (#39) (#47) (#72) (#73) (#85)
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant