Skip to content

fix: configurable run-service readiness timeout (issue #392) #417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Koan-Bot wants to merge 1 commit into
base: 2.0
Choose a base branch
from
Open

fix: configurable run-service readiness timeout (issue #392) #417

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
60 changes: 60 additions & 0 deletions t/AI/unit/Harness2.t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1393,4 +1393,64 @@ subtest 'perform_hard_stop catches grandchildren reparented mid-kill' => sub {
);
};

subtest '_wait_for_run_service_ready - returns handle when ready immediately' => sub {
my $dir = tempdir(CLEANUP => 1);
my $h = Test2::Harness2->new(workdir => $dir);
my $rid = 'run-test-ready';

# Plant a fake entry so _run_service_handle can build a handle.
my $call_count = 0;
my $fake_handle = bless {}, 'T2H2_Test_ReadyHandle_Immediate';
no warnings 'once';
*T2H2_Test_ReadyHandle_Immediate::ready = sub { 1 };

# Inject handle via _run_service_handle override.
local *Test2::Harness2::_run_service_handle = sub { $fake_handle };

my $got = $h->_wait_for_run_service_ready($rid);
is($got, $fake_handle, 'returns the handle object when ready() is true immediately');
};

subtest '_wait_for_run_service_ready - croaks with cap in message on timeout' => sub {
my $dir = tempdir(CLEANUP => 1);
my $h = Test2::Harness2->new(workdir => $dir);
my $rid = 'run-test-timeout';

my $fake_handle = bless {}, 'T2H2_Test_ReadyHandle_Never';
no warnings 'once';
*T2H2_Test_ReadyHandle_Never::ready = sub { 0 };

local *Test2::Harness2::_run_service_handle = sub { $fake_handle };

# Use a very short timeout so the test completes quickly.
local $ENV{YATH_RUN_SERVICE_READY_TIMEOUT} = 0;

my $ok = eval { $h->_wait_for_run_service_ready($rid); 1 };
my $err = $@;
ok(!$ok, 'croaks when handle never becomes ready');
like($err, qr/timeout waiting for run service '\Q$rid\E' to come up after 0s/,
'error message includes run_id and cap value');
};

subtest '_wait_for_run_service_ready - YATH_RUN_SERVICE_READY_TIMEOUT is honoured' => sub {
my $dir = tempdir(CLEANUP => 1);
my $h = Test2::Harness2->new(workdir => $dir);
my $rid = 'run-test-envtimeout';

my $fake_handle = bless {}, 'T2H2_Test_ReadyHandle_EnvNever';
no warnings 'once';
*T2H2_Test_ReadyHandle_EnvNever::ready = sub { 0 };

local *Test2::Harness2::_run_service_handle = sub { $fake_handle };

# Custom cap via env var.
local $ENV{YATH_RUN_SERVICE_READY_TIMEOUT} = 0;

my $ok = eval { $h->_wait_for_run_service_ready($rid); 1 };
my $err = $@;
ok(!$ok, 'croaks when handle never becomes ready with env-var cap');
like($err, qr/after 0s/, 'croak message reflects the env-var cap, not the hardcoded default');
unlike($err, qr/after 60s/, 'default 60s cap is not used when env var is set');
};

done_testing;
Loading