feat(cli): add runtime Node.js version check with clear error message#11
Open
lxcario wants to merge 1 commit into
Open
feat(cli): add runtime Node.js version check with clear error message#11lxcario wants to merge 1 commit into
lxcario wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When run on Node < 20, the CLI crashes with cryptic ESM/syntax errors. This PR adds a top-of-file version guard in
src/index.tsthat checksprocess.versions.nodeand exits with a clear, helpful message if the major version is below 20.Changes
src/index.ts(before any imports that use modern syntax)src/version-guard.test.tswith 8 tests verifying the guard logicTesting
npm run typecheck- cleannpm run lint:fix- cleannpx vitest run src/version-guard.test.ts- 8/8 passing