feat(cli): respect NO_COLOR environment variable per no-color.org#12
Open
lxcario wants to merge 1 commit into
Open
feat(cli): respect NO_COLOR environment variable per no-color.org#12lxcario wants to merge 1 commit into
lxcario wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CLI uses ANSI escape codes for the TTY progress ticker (
\x1b[2K\r). The NO_COLOR standard says tools should suppress color/ANSI output whenNO_COLORenv is set.Changes
isNoColor()utility insrc/lib/ticker.tsthat checks forNO_COLORin the environmentNO_COLORis set and the terminal is a TTY, the ticker emits plain-text lines viastderrWriteinstead of using ANSI escape sequences viarawWritenoColorparameter tocreateTicker()(defaults to env detection)NO_COLORto the environment variables table in DOCUMENTATION.mdisNoColorutility)Testing
npm run typecheck- cleannpm run lint:fix- cleannpx vitest run src/lib/ticker.spec.ts- 19/19 passing (all existing + 5 new)