fix(bundle): add retry loop to streamUrlToFile for transport failures#23
Open
crypticsaiyan wants to merge 1 commit into
Open
fix(bundle): add retry loop to streamUrlToFile for transport failures#23crypticsaiyan wants to merge 1 commit into
crypticsaiyan wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
streamUrlToFilepromised a "bounded retry on transport failures" in its JSDoc but made only one attempt. Transient network blips during downloads caused hard failures, forcing manual re-runs.The Fix
STREAM_URL_MAX_RETRIES) with a 1s delay for transport or mid-stream pipeline errors.ApiError) skip retries and fail immediately (e.g., expired presigned URLs will not recover).deps.sleepinjection for deterministic testing without real-world delays.Testing
Added 5 tests to
src/lib/bundle.test.tsverifying:TransportError)ApiError)sleepcalls between attemptsFiles Changed:
src/lib/bundle.tssrc/lib/bundle.test.ts