fix(test): validate failure get --out before API fetch#26
Open
SahilRakhaiya05 wants to merge 1 commit into
Open
fix(test): validate failure get --out before API fetch#26SahilRakhaiya05 wants to merge 1 commit into
SahilRakhaiya05 wants to merge 1 commit into
Conversation
runFailureGet now resolves and validates --out via resolveBundleDir and assertOutDirParentExists before calling GET /tests/{id}/failure, matching runArtifactGet and runCodeGet fast-fail behavior.
Adds regression tests asserting zero fetch calls on empty --out and missing parent dir paths.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
runFailureGet()had a comment claiming--outis validated before the network call, but it only assignedopts.outand immediately fetchedGET /tests/{id}/failure. Invalid paths (empty--out, missing parent directory, etc.) wasted an API call before failing with exit 5.runArtifactGet()andrunCodeGet()already fast-fail on bad--outpaths first; this alignsfailure get.The Fix
When
--outis provided:resolveBundleDir(opts.out)- rejects empty pathsassertOutDirParentExists(resolvedDir)- rejects missing parents / file targetswriteBundleTesting
src/commands/test.test.ts(zero fetch calls on invalid--out)npx vitest run src/commands/test.test.ts -t runFailureGet- 15 passednpm run typecheckandnpm run lint- passFiles changed:
src/commands/test.tssrc/commands/test.test.ts