fix(test,project): replace crashes with VALIDATION_ERROR on --since overflow and --password-file ENOENT#27
Open
crypticsaiyan wants to merge 1 commit into
Conversation
…verflow and --password-file ENOENT
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two edge cases involving invalid user input previously caused unhandled exceptions (raw Node stack traces and exit code 1) instead of standard typed validation errors (exit code 5).
--since(e.g.,99999999999h) caused aRangeError: Invalid time valuebecause it exceeded the valid JavaScript date range during.toISOString()conversion.--password-fileduring project creation or updates caused a rawENOENTcrash due to an unguardedreadFileSynccall.The Fix
Number.isFinite(result.getTime())check inparseDuration(src/commands/test.ts) to intercept invalid dates and throw alocalValidationErrorbefore attempting conversion.readFileSynccalls for the password file intry/catchblocks (src/commands/project.ts) to gracefully capture read errors and emit typed validation errors.Testing & Validation
Regression Tests Added:
src/commands/test.result.history.spec.tsverifying that extreme--sincevalues now trigger graceful validation errors instead of crashing.src/commands/project.test.tsensuring missing password files are caught during bothcreateandupdateoperations.CI Gates: All local checks pass.
typecheck)Files Changed:
src/commands/test.tssrc/commands/project.tssrc/commands/test.result.history.spec.tssrc/commands/project.test.ts