Skip to content

Fix for "LoDMips is not in non-descending order" #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
helpful-fox-senko-san wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Fix for "LoDMips is not in non-descending order" #102

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 9 additions & 10 deletions xivModdingFramework/Textures/FileTypes/Tex.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,15 +135,6 @@ internal static TexHeader ReadTexHeader(BinaryReader br, long offset = -1)
/// <returns>Byte array containing the header data.</returns>
internal byte[] ToBytes()
{
if (this.LoDMips[1] < this.LoDMips[0] || this.LoDMips[2] < this.LoDMips[1])
throw new InvalidOperationException("LoDMips is not in non-descending order.");
if (this.LoDMips[2] >= this.MipCount)
throw new InvalidOperationException("All LoDMips must be strictly lesser than MipCount.");
if (this.MipFlag > 15)
throw new InvalidOperationException("MipFlag must be strictly lesser than 16.");
if (this.MipCount > 13)
throw new InvalidOperationException("MipCount must be strictly lesser than 14.");

var res = new byte[_TexHeaderSize];
var bw = new BinaryWriter(new MemoryStream(res, true));
bw.Write(this.Attributes);
Expand Down Expand Up @@ -209,14 +200,22 @@ internal static (bool HeaderChanged, long CalculatedTexSize) FixUpBrokenMipOffse
header.MipCount = (byte)(mipLevel + 1);
}

uint maxLodMip = 0;
// Update LoDMips in case we removed a referenced mipmap
// ... or if the values are not correctly in ascending order
for (int lodLevel = 0; lodLevel < 3; ++lodLevel)
{
if (header.LoDMips[lodLevel] >= header.MipCount)
{
modified = true;
header.LoDMips[lodLevel] = (uint)(header.MipCount - 1);
}
if (header.LoDMips[lodLevel] < maxLodMip)
{
modified = true;
header.LoDMips[lodLevel] = maxLodMip;
}
maxLodMip = header.LoDMips[lodLevel];
}

// Fill out the rest of table with zeroes
Expand Down Expand Up @@ -1124,7 +1123,7 @@ internal static List<byte> CreateTexFileHeader(XivTexFormat format, int newWidth

headerData.AddRange(BitConverter.GetBytes(0)); // LoD 0 Mip
headerData.AddRange(BitConverter.GetBytes(newMipCount > 1 ? 1 : 0)); // LoD 1 Mip
headerData.AddRange(BitConverter.GetBytes(newMipCount > 2 ? 2 : 0)); // LoD 2 Mip
headerData.AddRange(BitConverter.GetBytes(newMipCount > 2 ? 2 : (newMipCount - 1))); // LoD 2 Mip

var mipMapUncompressedOffset = 80;

Expand Down