Test Swift hard merge by simcariou · Pull Request #1618 · ThalesGroup/fred

simcariou · 2026-05-11T19:27:30Z

Summary

Describe what changed and why.

Mandatory Checklist

I followed docs/platform/DEVELOPER_CONTRACT.md.
The change is minimal and avoids over-engineering.
I ran make code-quality in every touched project.
I ran make test in every touched project.
I did not introduce unit/default tests that require external services.
Any test requiring external services is marked @pytest.mark.integration.
I updated documentation when behavior or conventions changed.

Validation Notes

Paste the exact commands and short results.

Risk / Rollback

State main risk and rollback approach.

…sitionning

Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>

…ing method' Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>

Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>

…ing method' Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>

…eption'' Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>

Resolved fred-core rename conflict (fred-core/ → libs/fred-core/). Regenerated libs/fred-core/uv.lock after merge. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

- Add RuntimeErrorEvent(kind="execution_error", message) to fred-sdk: RuntimeEventKind enum, class, and RuntimeEvent union. Before this, the exception handler yielded {"error": str(exc)} with no kind field — silently ignored by any SSE client dispatching on kind. - Wire RuntimeErrorEvent in fred-runtime _iterate_runtime_event_payloads exception handler (replaces bare dict yield). - Update TurnPersistedEvent docstring: explicitly documented as NOT emitted live over the SSE stream; final remains the only reliable end-of-turn signal. Type kept for future use. - Update /agents/execute/stream docstring: document stream termination (connection close after final), RuntimeErrorEvent as the error signal, and TurnPersistedEvent non-delivery. - Update RuntimeExecuteRequest.runtime_context description: note that user_id defaults to "unknown" in agent_id direct mode unless explicitly provided. - Regenerate frontend runtimeOpenApi.ts. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Add section 0 with a plain HTTP SSE sequence diagram, the two execution paths (managed vs direct), session continuity rule, and the error signal. Update section 5 to reflect RuntimeErrorEvent (replaces bare-dict gap note) and clarify TurnPersistedEvent as schema-only, not emitted over SSE. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Add section 0.1 with a step-by-step sequence diagram of the managed execution path (bootstrap → agent list → prepare-execution → runtime SSE), explaining why control-plane is in the middle for prepare-execution but not for streaming, and what ExecutionGrant contains. Update section 8 (SSE contract gaps) from open issues to resolved, referencing commit eedbc61. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Mark all four 3b.6 SSE contract corrections as fixed (commit eedbc61). Add 3b.8: in no-security/standalone mode (security_enabled=false), team_id must default to "personal" automatically in fred-runtime and fred-agent-chat when not explicitly provided. Without this, checkpoints, KPIs, and history rows have no team identity even in the simplest single-user deployment. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

…mode (3b.8) In no-security mode (security_enabled=False) the runtime now implicitly resolves team_id to "personal" when the caller omits it, so standalone deployments behave correctly without requiring the client to pass team_id on every request. Thread security_enabled through _stream → _iterate_runtime_event_payloads. CLI client also defaults effective_team_id to "personal" when no login config is present. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

…sonal default Bug: _stream() was passing raw team_id=None to _emit_turn_completed() and _write_turn_history() while the "personal" default lived only inside _iterate_runtime_event_payloads(), invisible to the caller. Fix: move team resolution to _stream() before any downstream call. Remove security_enabled from _iterate_runtime_event_payloads() (only purpose was team resolution; caller now owns it). Also: - CLI startup banner now prints active team: "[chat] team : personal" - Test renamed + rewritten to assert the resolved team_id arriving at _iterate - RUNTIME-EXECUTION-CONTRACT.md: standalone/no-security paragraph in section 0 - BACKLOG.md: 3b.8 fully done; 3b.9 checkpoint retention policy added Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

…dd error counter Three production KPI corrections in _emit_turn_completed(): 1. Strip session_id, exchange_id, user_id, agent_instance_id from Prometheus dims — these are per-turn UUIDs that would create one time-series per turn (cardinality bomb). They remain available in history rows and SSE logs. 2. Set finish_reason="error" when execution_error is emitted instead of final, making the histogram queryable by outcome without raw label inspection. 3. Add agent.turn_error_total counter emitted only on error turns, enabling Prometheus alerting on error rate without histogram label filtering. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

…entory Covers fred-runtime, fred-sdk, and fred-agent-chat CLI across 13 feature areas with status, source files, known gaps, and a standalone validation checklist. Records 6 known defects (KD-1 through KD-6) with severity ratings. Supersedes ad-hoc per-session gap discovery. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* #1587 implement the team and graph agent memory * #1587 doc and unbit test updates * #1587 update cicd * #1587 update cicd * #1587 update cicd * #1587 update cicd * #1587 code quality * #1587 route security * #1587 code quality --------- Co-authored-by: Dimitri Tombroff <dimitri.tombroff@gmail.com>

* #1595 better and useful test coverage * #1595 better and useful test coverage code quality * 1595 update docs * 1595 update docs * 1595 make test assistant really mocked * #1595 code quality * 1595 api drift --------- Co-authored-by: Dimitri Tombroff <dimitri.tombroff@gmail.com>

…prompt libraries

Reduces from 275 to 212 lines. New structure: - Prime directive: extend, do not duplicate - Reuse audit (ID lookup → backlog → contract → RFC → convergence) - Decision tree for what to write where - Task lifecycle (Steps 1-6 + close-out, unchanged) - Task IDs (condensed; legacy table replaced by one-liner pointer to id-legend.yaml) - Operational queries + mandatory read order - Git conventions, when-stuck rules, what-lives-where map Removed: Non-Negotiable Defaults (duplicate), Fred Runtime Topology narrative, Current Architecture State (→ docs/ARCHITECTURE.md), full coding constraints (→ docs/CONVENTIONS.md). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Moves General, Python, and Frontend coding constraints (including testing strategy) from the old CLAUDE.md into a dedicated reference file. CLAUDE.md now points to this file for Step 4 constraints. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

…TURE.md Short entry point (44 lines): one sentence per component, pointers to platform/ and design/ for detail. Replaces the "Fred Runtime Topology" and "Current Architecture State" sections removed from CLAUDE.md. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

124-line guide for Claire and Arnaud: VS Code + Claude Code setup, the four files that matter, example questions, weekly rhythm, how to update files with Claude's help, when to ask Claude vs a human, and what this guide does not cover. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

README.md (75 lines): definition of a track, index table of 7 active and 6 recently closed tracks, manifest template, and authoring rules. M1-multi-agent-memory.md (49 lines): worked example built from actual id-legend.yaml data and MULTI-AGENT-MEMORY-BACKLOG.md — RFC ref, backlog ref, 4 open hardening branches (M1-F.1..F.4), 5 closed phases, notes on sequencing and P1-F dependency. Other tracks marked "to write" for follow-up sessions. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

-			if len(sessionIDs) > 0 {
-				sessionID = sessionIDs[i]
+			sessionID := cfg.SessionID
+			if cfg.Protocol != "sse" && len(wsSessionIDs) > 0 {


+    def test_delete_existing_returns_value(self) -> None:
+        cache: ThreadSafeLRUCache[str, int] = ThreadSafeLRUCache()
+        cache.set("k", 99)
+        assert cache.delete("k") == 99


+
+    def test_delete_missing_returns_none(self) -> None:
+        cache: ThreadSafeLRUCache[str, int] = ThreadSafeLRUCache()
+        assert cache.delete("ghost") is None


Dimitri Tombroff and others added 30 commits April 16, 2026 13:02

#1514 added new libraries and new fred-agents apps to facilitate tran…

05c771f

…sitionning

Merge branch 'develop' into 1514-propose-the-agentic-pod-implentation

f4e5b0f

Potential fix for pull request finding 'Non-iterable used in for loop'

4473106

Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>

#1514 use the libs fred-core to remove duplicate code

774d93f

#1514 fully tested from a previous develop instance

9ce6831

Potential fix for pull request finding 'Unnecessary pass'

dc7de21

Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>

Potential fix for pull request finding 'Unnecessary pass'

54dfa29

Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>

Potential fix for pull request finding 'Unnecessary pass'

c3e55d8

Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>

Potential fix for pull request finding 'Signature mismatch in overrid…

75d2392

…ing method' Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>

#1514 code quality

480d1c0

Potential fix for pull request finding 'Statement has no effect'

9858478

Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>

Potential fix for pull request finding 'Signature mismatch in overrid…

1700aa1

…ing method' Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>

#1514 code quality

08003b8

#1514 changed fred-core path in github workflow

65e4e68

#1514 merged latest develop

47fb461

Potential fix for pull request finding 'Except block handles 'BaseExc…

dfe58da

…eption'' Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>

Potential fix for pull request finding 'Except block handles 'BaseExc…

e8907db

…eption'' Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>

#1514 code quality

1df3c4a

first phase one to five refer to backlog files

47aa7c8

make the benchmark tool capable to speak http sse

d90ca0b

Merge develop into agentic-pod

4982482

Resolved fred-core rename conflict (fred-core/ → libs/fred-core/). Regenerated libs/fred-core/uv.lock after merge. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

make the personal team used by default in standalone mode

8dbdfe0

Dimitri Tombroff and others added 27 commits May 4, 2026 04:52

pass to swift v2.0

210c399

merged latest kea

b69de9c

update baseline.json

caf15a1

sound basis to start feature branches

a3c1081

align all published releases on 2.0.1

6728ff2

added eval mode to cli

5542f6a

Add agent evaluation backlog

4f9a29a

#1587 api drift

e7d3e2e

merged memory

1640bb1

align the UI and cli to have similar support

27c731a

keep cli aligned with latest configuration design

d34e78d

better top level doc

13cfd43

1595 api drift

8663748

start end to end testing

f3e82a4

bootstrap the organisation assistance

1e11238

bootstrap the organisation assistance

6a4d5a9

improve development and organisation tracking

284a499

code quality and better test coverage

5e9558d

lots of clean progress and fundamental work to make emerge the right …

d9cf362

…prompt libraries

improve organisation and instructions for team review

65fd3f7

github-code-quality Bot found potential problems May 11, 2026

View reviewed changes

Comment thread developer_tools/benchmarks/ws_bench.go

if len(sessionIDs) > 0 {

sessionID = sessionIDs[i]

sessionID := cfg.SessionID

if cfg.Protocol != "sse" && len(wsSessionIDs) > 0 {

github-code-quality Bot found potential problems May 11, 2026

View reviewed changes

simcariou closed this May 12, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Test Swift hard merge#1618

Test Swift hard merge#1618
simcariou wants to merge 81 commits into
mainfrom
swift

simcariou commented May 11, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

simcariou commented May 11, 2026

Summary

Mandatory Checklist

Validation Notes

Risk / Rollback

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants