Swift by simcariou · Pull Request #1657 · ThalesGroup/fred

simcariou · 2026-05-27T09:38:52Z

Summary

Describe what changed and why.

Mandatory Checklist

I followed docs/platform/DEVELOPER_CONTRACT.md.
The change is minimal and avoids over-engineering.
I ran make code-quality in every touched project.
I ran make test in every touched project.
I did not introduce unit/default tests that require external services.
Any test requiring external services is marked @pytest.mark.integration.
I updated documentation when behavior or conventions changed.

Validation Notes

Paste the exact commands and short results.

Risk / Rollback

State main risk and rollback approach.

…sitionning

Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>

…ing method' Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>

Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>

…ing method' Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>

…eption'' Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>

Resolved fred-core rename conflict (fred-core/ → libs/fred-core/). Regenerated libs/fred-core/uv.lock after merge. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

- Add RuntimeErrorEvent(kind="execution_error", message) to fred-sdk: RuntimeEventKind enum, class, and RuntimeEvent union. Before this, the exception handler yielded {"error": str(exc)} with no kind field — silently ignored by any SSE client dispatching on kind. - Wire RuntimeErrorEvent in fred-runtime _iterate_runtime_event_payloads exception handler (replaces bare dict yield). - Update TurnPersistedEvent docstring: explicitly documented as NOT emitted live over the SSE stream; final remains the only reliable end-of-turn signal. Type kept for future use. - Update /agents/execute/stream docstring: document stream termination (connection close after final), RuntimeErrorEvent as the error signal, and TurnPersistedEvent non-delivery. - Update RuntimeExecuteRequest.runtime_context description: note that user_id defaults to "unknown" in agent_id direct mode unless explicitly provided. - Regenerate frontend runtimeOpenApi.ts. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Add section 0 with a plain HTTP SSE sequence diagram, the two execution paths (managed vs direct), session continuity rule, and the error signal. Update section 5 to reflect RuntimeErrorEvent (replaces bare-dict gap note) and clarify TurnPersistedEvent as schema-only, not emitted over SSE. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Add section 0.1 with a step-by-step sequence diagram of the managed execution path (bootstrap → agent list → prepare-execution → runtime SSE), explaining why control-plane is in the middle for prepare-execution but not for streaming, and what ExecutionGrant contains. Update section 8 (SSE contract gaps) from open issues to resolved, referencing commit eedbc61. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Mark all four 3b.6 SSE contract corrections as fixed (commit eedbc61). Add 3b.8: in no-security/standalone mode (security_enabled=false), team_id must default to "personal" automatically in fred-runtime and fred-agent-chat when not explicitly provided. Without this, checkpoints, KPIs, and history rows have no team identity even in the simplest single-user deployment. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

…mode (3b.8) In no-security mode (security_enabled=False) the runtime now implicitly resolves team_id to "personal" when the caller omits it, so standalone deployments behave correctly without requiring the client to pass team_id on every request. Thread security_enabled through _stream → _iterate_runtime_event_payloads. CLI client also defaults effective_team_id to "personal" when no login config is present. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

…sonal default Bug: _stream() was passing raw team_id=None to _emit_turn_completed() and _write_turn_history() while the "personal" default lived only inside _iterate_runtime_event_payloads(), invisible to the caller. Fix: move team resolution to _stream() before any downstream call. Remove security_enabled from _iterate_runtime_event_payloads() (only purpose was team resolution; caller now owns it). Also: - CLI startup banner now prints active team: "[chat] team : personal" - Test renamed + rewritten to assert the resolved team_id arriving at _iterate - RUNTIME-EXECUTION-CONTRACT.md: standalone/no-security paragraph in section 0 - BACKLOG.md: 3b.8 fully done; 3b.9 checkpoint retention policy added Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

…dd error counter Three production KPI corrections in _emit_turn_completed(): 1. Strip session_id, exchange_id, user_id, agent_instance_id from Prometheus dims — these are per-turn UUIDs that would create one time-series per turn (cardinality bomb). They remain available in history rows and SSE logs. 2. Set finish_reason="error" when execution_error is emitted instead of final, making the histogram queryable by outcome without raw label inspection. 3. Add agent.turn_error_total counter emitted only on error turns, enabling Prometheus alerting on error rate without histogram label filtering. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

…entory Covers fred-runtime, fred-sdk, and fred-agent-chat CLI across 13 feature areas with status, source files, known gaps, and a standalone validation checklist. Records 6 known defects (KD-1 through KD-6) with severity ratings. Supersedes ad-hoc per-session gap discovery. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

…-policy knowledge flow local policy

…-documents-scrlling-arrows feature/frontend-adds-display-documents-scrlling-arrows

…cy limit is reached (#1640) * feat: Cap traffic on fred-agents via uvicorn by throwing 503 when concurrency limit reached * Update __main__.py * fix: code-quality * fix: code-quality * fix: make update-runtime-api + npm audit fix * Update docs/swift/data/id-legend.yaml

…s of progresses in the new chat UI

…iable prompts for specific MCP servers (#1649) * feat: Move base prompts to McpServerConfiguration to enforce non negotiable prompts for specific MCP servers * merge swift in 1648-move-tool-behavioral-contracts-to-mcp_catalog-agent_instructions * Revert "merge swift in 1648-move-tool-behavioral-contracts-to-mcp_catalog-agent_instructions" This reverts commit 8b2b586. * fix: code quality * fix: RTK slices generation in frontend makefile * impr: Add target to update all apis * impr: update mcp rfc * impr: PMO workflow * fix: code-quality-fix on all the services and apps * fix: Add slices to prettierignore to avoid fails in the code-quality-fix make step

* Expose agent tags in EvalTrace * Document agent tags in EvalTrace * fix: update runtime openapi slices --------- Co-authored-by: Simon Cariou <simon.cariou@thalesgroup.com>

-			if len(sessionIDs) > 0 {
-				sessionID = sessionIDs[i]
+			sessionID := cfg.SessionID
+			if cfg.Protocol != "sse" && len(wsSessionIDs) > 0 {


Dimitri Tombroff and others added 30 commits April 16, 2026 13:02

#1514 added new libraries and new fred-agents apps to facilitate tran…

05c771f

…sitionning

Merge branch 'develop' into 1514-propose-the-agentic-pod-implentation

f4e5b0f

Potential fix for pull request finding 'Non-iterable used in for loop'

4473106

Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>

#1514 use the libs fred-core to remove duplicate code

774d93f

#1514 fully tested from a previous develop instance

9ce6831

Potential fix for pull request finding 'Unnecessary pass'

dc7de21

Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>

Potential fix for pull request finding 'Unnecessary pass'

54dfa29

Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>

Potential fix for pull request finding 'Unnecessary pass'

c3e55d8

Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>

Potential fix for pull request finding 'Signature mismatch in overrid…

75d2392

…ing method' Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>

#1514 code quality

480d1c0

Potential fix for pull request finding 'Statement has no effect'

9858478

Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>

Potential fix for pull request finding 'Signature mismatch in overrid…

1700aa1

…ing method' Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>

#1514 code quality

08003b8

#1514 changed fred-core path in github workflow

65e4e68

#1514 merged latest develop

47fb461

Potential fix for pull request finding 'Except block handles 'BaseExc…

dfe58da

…eption'' Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>

Potential fix for pull request finding 'Except block handles 'BaseExc…

e8907db

…eption'' Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>

#1514 code quality

1df3c4a

first phase one to five refer to backlog files

47aa7c8

make the benchmark tool capable to speak http sse

d90ca0b

Merge develop into agentic-pod

4982482

Resolved fred-core rename conflict (fred-core/ → libs/fred-core/). Regenerated libs/fred-core/uv.lock after merge. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

make the personal team used by default in standalone mode

8dbdfe0

marcfawaz and others added 28 commits May 19, 2026 09:42

Merge pull request #1628 from marcfawaz/feature/knowledge-flow-search…

8474a54

…-policy knowledge flow local policy

feature/frontend-adds-display-documents-scrlling-arrows

c927dd7

Merge pull request #1630 from marcfawaz/feature/frontend-adds-display…

1e4146a

…-documents-scrlling-arrows feature/frontend-adds-display-documents-scrlling-arrows

Update AGENTS.md AGENT.md file to be coherent with CLAUDE.md (#1637)

dd4483f

define new task for markdown rendering

6056a39

#1638 improve test agent with required markdown variations

a637ae4

added math markdown mermaid support to chat markdown renderer

57f0b8a

cleanup old code to pass everything to the rework part

e8869fe

search form

18c735a

remove old legacy code

9680cd5

upsate rfs backlogs and sprint schedule

286650f

use mistral by default

d42d394

replug the genral assistant with tools

2b0d7fa

pass on consistency for instructions rfc and backlogs

9bf9216

#1650 proposal for team level configuration

36ae2ad

#1650 first try with HTML for top level architecture page

80884e1

specify and improved the chain of thought both n backend and ui

0ca651c

big cleaning pass on all frontend design violations

df41c87

add tests to frontend now moved to apps fixed many violations and lot…

99c8d09

…s of progresses in the new chat UI

code quality and tests

02ec806

mardown cleanup

16eaad3

end of day cleanup and doc update

efe056f

add chat ui features

58cadea

merged latest swift

46729d9

RFC and backlog for helm chart related work

42bd1b5

Expose agent tags in EvalTrace (#1653)

63d918a

* Expose agent tags in EvalTrace * Document agent tags in EvalTrace * fix: update runtime openapi slices --------- Co-authored-by: Simon Cariou <simon.cariou@thalesgroup.com>

github-code-quality Bot found potential problems May 27, 2026

View reviewed changes

Comment thread developer_tools/benchmarks/ws_bench.go

if len(sessionIDs) > 0 {

sessionID = sessionIDs[i]

sessionID := cfg.SessionID

if cfg.Protocol != "sse" && len(wsSessionIDs) > 0 {

simcariou closed this May 27, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Swift - #1657

Swift#1657
simcariou wants to merge 117 commits into
mainfrom
swift

simcariou commented May 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

simcariou commented May 27, 2026

Summary

Mandatory Checklist

Validation Notes

Risk / Rollback

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants