Use stable sort again#295
Merged
maliberty merged 1 commit intoFeb 25, 2026
Merged
Conversation
openroad-ci
force-pushed
the
stable_sort
branch
from
38c556d to
a17b673
Compare
Contributor
|
I have rebased this PR onto #290 as the src/sta/ submodule already has that change |
Before the multi-mode refactor the sort helpers wrapped stable_sort, switch to stable_sort again as the sorting influences which vertex is returned from Sta::worstSlack(). Signed-off-by: Martin Povišer <povik@cutebit.org>
openroad-ci
force-pushed
the
stable_sort
branch
from
a17b673 to
fe31eef
Compare
Contributor
|
I have rebased back |
|
|
maliberty
approved these changes
Feb 25, 2026
Member
|
OR tests will need updating but this looks correct |
QuantamHD
pushed a commit
to QuantamHD/OpenSTA
that referenced
this pull request
Mar 24, 2026
…ct#295 Signed-off-by: James Cherry <cherry@parallaxsw.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before the multi-mode refactor the sort helpers wrapped stable_sort, switch to stable_sort again as the sorting influences which vertex is returned from Sta::worstSlack().