-
Notifications
You must be signed in to change notification settings - Fork 246
Sta update latest 0514 #363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dsengupta0628
wants to merge
9
commits into
The-OpenROAD-Project:master
Choose a base branch
from
The-OpenROAD-Project-staging:sta_update_latest_0514
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
6eb6911
regression
jjcherry56 7e68e45
mv is_object to Util.i
jjcherry56 8cbd400
Liberty power_down_function parse resolves #428
jjcherry56 30f862b
ord ctest turds
jjcherry56 4c8ef5b
make report field
jjcherry56 1738021
expose levelizeobserver (#433)
dsengupta0628 85f3840
latest changes 5/14 including generalize path report field and expose…
dsengupta0628 1475ab0
upstream changes 5/14 plus fix report generic field
dsengupta0628 337c738
add reportField instead of line+ address Gemini feedback
dsengupta0628 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,59 @@ | ||
| // OpenSTA, Static Timing Analyzer | ||
| // Copyright (c) 2026, Parallax Software, Inc. | ||
| // | ||
| // This program is free software: you can redistribute it and/or modify | ||
| // it under the terms of the GNU General Public License as published by | ||
| // the Free Software Foundation, either version 3 of the License, or | ||
| // (at your option) any later version. | ||
| // | ||
| // This program is distributed in the hope that it will be useful, | ||
| // but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
| // MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
| // GNU General Public License for more details. | ||
| // | ||
| // You should have received a copy of the GNU General Public License | ||
| // along with this program. If not, see <https://www.gnu.org/licenses/>. | ||
| // | ||
| // The origin of this software must not be misrepresented; you must not | ||
| // claim that you wrote the original software. | ||
| // | ||
| // Altered source versions must be plainly marked as such, and must not be | ||
| // misrepresented as being the original software. | ||
| // | ||
| // This notice may not be removed or altered from any source distribution. | ||
|
|
||
| #pragma once | ||
|
|
||
| namespace sta { | ||
|
|
||
| class Vertex; | ||
| class Search; | ||
| class GraphDelayCalc; | ||
|
|
||
| // Observer fired by Levelize during (re)levelization. Downstream consumers | ||
| // override the two hooks to invalidate caches that depend on vertex levels. | ||
| class LevelizeObserver | ||
| { | ||
| public: | ||
| virtual ~LevelizeObserver() = default; | ||
| virtual void levelsChangedBefore() = 0; | ||
| virtual void levelChangedBefore(Vertex *vertex) = 0; | ||
| }; | ||
|
|
||
| // Default observer installed by Sta::makeObservers. Forwards level-change | ||
| // events to Search and GraphDelayCalc so their internal caches stay | ||
| // consistent. Subclass and override to extend (call the base methods first, | ||
| // then add your own invalidation). | ||
| class StaLevelizeObserver : public LevelizeObserver | ||
| { | ||
| public: | ||
| StaLevelizeObserver(Search *search, GraphDelayCalc *graph_delay_calc); | ||
| void levelsChangedBefore() override; | ||
| void levelChangedBefore(Vertex *vertex) override; | ||
|
|
||
| private: | ||
| Search *search_; | ||
| GraphDelayCalc *graph_delay_calc_; | ||
| }; | ||
|
|
||
| } // namespace sta |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In
LibertyGroup::findAttrInt, theelseblock assumes that if an attribute value is not a float, it must be a string that can be parsed as a long. However,LibertyAttrValuecould potentially hold other types depending on the parser state. AccessingstringValue()without verifying the type (e.g., viaisString()) might lead to undefined behavior or assertions if the value is of an unexpected type.