clone_from/push_to: Improve consistency between actions.#9
Open
mithro wants to merge 1 commit intoThe-OpenROAD-Project:mainfrom
Open
clone_from/push_to: Improve consistency between actions.#9mithro wants to merge 1 commit intoThe-OpenROAD-Project:mainfrom
mithro wants to merge 1 commit intoThe-OpenROAD-Project:mainfrom
Conversation
Make consistent the following; * Wording in output. * Checking of inputs. * Git environment variables. * Quoting of command line arguments. * How optional arguments are given to git using `GIT_ARGS`. Signed-off-by: Tim 'mithro' Ansell <tansell@google.com>
tspyrou
approved these changes
May 24, 2021
QuantamHD
approved these changes
Jun 10, 2021
| # Checkout if needed | ||
| if [[ '${{ inputs.checkout }}' != 'true' ]]; then | ||
| GIT_CLONE_ARGS="--no-checkout" | ||
| export GIT_ARGS='' |
There was a problem hiding this comment.
Minor nit: the quote types should match the rest of the file. It looks like in most cases we're doing ". Other than that this looks good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make consistent the following;
GIT_ARGS.Signed-off-by: Tim 'mithro' Ansell tansell@google.com