added Unique Binary Search Tree with dynamic programming#210
Open
ShahrearBinAmin wants to merge 2 commits intoTheAlgorithms:masterfrom
Open
added Unique Binary Search Tree with dynamic programming#210ShahrearBinAmin wants to merge 2 commits intoTheAlgorithms:masterfrom
ShahrearBinAmin wants to merge 2 commits intoTheAlgorithms:masterfrom
Conversation
Author
|
Can you please check this? @akashgk |
akashgk
reviewed
Jan 10, 2023
| // Given an integer n, return the number of structurally unique BST's (binary search trees) | ||
| // which has exactly n nodes of unique values from 1 to n. | ||
|
|
||
| class UniqueBST { |
Member
There was a problem hiding this comment.
I think this class is not serving any purpose. we can remove it.
akashgk
reviewed
Jan 10, 2023
| // which has exactly n nodes of unique values from 1 to n. | ||
|
|
||
| class UniqueBST { | ||
| int solve(int i, List<int> dp) { |
Member
There was a problem hiding this comment.
can you add some comments to explain the algorithm
akashgk
requested changes
Jan 10, 2023
Comment on lines
+27
to
+32
| test('Test Case 1: Input 3, Output - 5', () { | ||
| expect(uniqueBST.numTrees(3), 5); | ||
| }); | ||
|
|
||
| test('Test Case 2: Input 1, Output - 1', () { | ||
| expect(uniqueBST.numTrees(1), 1); |
Member
There was a problem hiding this comment.
could you please add more test cases ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Welcome to Dart community
Describe your change:
Checklist:
Fixes: #{$ISSUE_NO}.