Open
Conversation
Make it more comfortable to read
akashgk
reviewed
Sep 26, 2023
Comment on lines
20
to
31
| void main() { | ||
| List list = [0, 1, 1, 2, 3, 5, 8, 13, 21, 34, 55, 89]; | ||
| int x = 55; | ||
| int search = 55; | ||
| int n = list.length; | ||
| int index = binary_search(list, 0, n - 1, x); | ||
| int index = binary_search(list, 0, n - 1, search); | ||
| print('list:'); | ||
| print(list); | ||
| if (index != -1) { | ||
| print('$x found at positions: $index'); | ||
| print('$search found at positions: $index'); | ||
| } else { | ||
| print('$x Not found'); | ||
| print('$search Not found'); | ||
| } |
Member
There was a problem hiding this comment.
Since, We are improiving this file. I would recommend you add some test to this file as well.
akashgk
requested changes
Sep 26, 2023
Member
akashgk
left a comment
akashgk
left a comment
There was a problem hiding this comment.
It would be great if you could add some test to this file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make it more comfortable to read
Welcome to Dart community
Describe your change:
Checklist:
Fixes: #{$ISSUE_NO}.