fix: rgbToHsl no longer mutates its input array#1908
Open
InukaWijerathna wants to merge 1 commit into
Open
Conversation
rgbToHsl aliased its argument with colorHsl = colorRgb instead of copying it, then overwrote colorHsl in place and returned that same array, destroying the caller's original RGB values. Copy the input with [...colorRgb] instead, and add a regression test asserting the input is left unchanged.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1908 +/- ##
=======================================
Coverage 85.91% 85.91%
=======================================
Files 379 379
Lines 19778 19778
Branches 3016 3015 -1
=======================================
Hits 16993 16993
Misses 2785 2785 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1907.
rgbToHslaliased its argument (let colorHsl = colorRgb) instead of copying it, then wrote the HSL result into that same array and returned it. Any caller that kept a reference to its RGB input had that array silently overwritten with the HSL output (input === resultwastrue).Fixes the alias to a copy (
[...colorRgb]), per the fix suggested in the issue, and adds a regression test asserting the input array is left unchanged after conversion.The existing HSL conversion math is untouched — only the in-place mutation is fixed.