Fix bubble sort logic and add comments

sorts/bubble_sort.py

@@ -1,132 +1,69 @@
 from typing import Any
 
+"""
+Bubble Sort Algorithms
+
+This module provides iterative and optimized implementations
+of the Bubble Sort algorithm.
+
+Time Complexity:
+    Best Case: O(n)
+    Average Case: O(n^2)
+    Worst Case: O(n^2)
+
+Space Complexity:
+    O(1)
+"""
+
 
 def bubble_sort_iterative(collection: list[Any]) -> list[Any]:
-    """Pure implementation of bubble sort algorithm in Python
-
-    :param collection: some mutable ordered collection with heterogeneous
-    comparable items inside
-    :return: the same collection ordered by ascending
-
-    Examples:
-    >>> bubble_sort_iterative([0, 5, 2, 3, 2])
-    [0, 2, 2, 3, 5]
-    >>> bubble_sort_iterative([])
-    []
-    >>> bubble_sort_iterative([-2, -45, -5])
-    [-45, -5, -2]
-    >>> bubble_sort_iterative([-23, 0, 6, -4, 34])
-    [-23, -4, 0, 6, 34]
-    >>> bubble_sort_iterative([0, 5, 2, 3, 2]) == sorted([0, 5, 2, 3, 2])
-    True
-    >>> bubble_sort_iterative([]) == sorted([])
-    True
-    >>> bubble_sort_iterative([-2, -45, -5]) == sorted([-2, -45, -5])
-    True
-    >>> bubble_sort_iterative([-23, 0, 6, -4, 34]) == sorted([-23, 0, 6, -4, 34])
-    True
-    >>> bubble_sort_iterative(['d', 'a', 'b', 'e']) == sorted(['d', 'a', 'b', 'e'])
-    True
-    >>> bubble_sort_iterative(['z', 'a', 'y', 'b', 'x', 'c'])
-    ['a', 'b', 'c', 'x', 'y', 'z']
-    >>> bubble_sort_iterative([1.1, 3.3, 5.5, 7.7, 2.2, 4.4, 6.6])
-    [1.1, 2.2, 3.3, 4.4, 5.5, 6.6, 7.7]
-    >>> bubble_sort_iterative([1, 3.3, 5, 7.7, 2, 4.4, 6])
-    [1, 2, 3.3, 4.4, 5, 6, 7.7]
-    >>> import random
-    >>> collection_arg = random.sample(range(-50, 50), 100)
-    >>> bubble_sort_iterative(collection_arg) == sorted(collection_arg)
-    True
-    >>> import string
-    >>> collection_arg = random.choices(string.ascii_letters + string.digits, k=100)
-    >>> bubble_sort_iterative(collection_arg) == sorted(collection_arg)
-    True
     """
-    length = len(collection)
-    for i in reversed(range(length)):
+    Bubble Sort (Iterative)
+
+    Sorts a list in ascending order using the bubble sort algorithm.
+
+    :param collection: A mutable list of comparable elements
+    :return: Sorted list
+    """
+
+    n = len(collection)
+    if n < 2:
+        return collection
+
+    for i in range(n):
         swapped = False
-        for j in range(i):
+        for j in range(n - i - 1):  # removed unnecessary start=0
             if collection[j] > collection[j + 1]:
-                swapped = True
                 collection[j], collection[j + 1] = collection[j + 1], collection[j]
+                swapped = True
+
         if not swapped:
-            break  # Stop iteration if the collection is sorted.
+            break
+
     return collection
 
 
-def bubble_sort_recursive(collection: list[Any]) -> list[Any]:
-    """It is similar iterative bubble sort but recursive.
-
-    :param collection: mutable ordered sequence of elements
-    :return: the same list in ascending order
-
-    Examples:
-    >>> bubble_sort_recursive([0, 5, 2, 3, 2])
-    [0, 2, 2, 3, 5]
-    >>> bubble_sort_iterative([])
-    []
-    >>> bubble_sort_recursive([-2, -45, -5])
-    [-45, -5, -2]
-    >>> bubble_sort_recursive([-23, 0, 6, -4, 34])
-    [-23, -4, 0, 6, 34]
-    >>> bubble_sort_recursive([0, 5, 2, 3, 2]) == sorted([0, 5, 2, 3, 2])
-    True
-    >>> bubble_sort_recursive([]) == sorted([])
-    True
-    >>> bubble_sort_recursive([-2, -45, -5]) == sorted([-2, -45, -5])
-    True
-    >>> bubble_sort_recursive([-23, 0, 6, -4, 34]) == sorted([-23, 0, 6, -4, 34])
-    True
-    >>> bubble_sort_recursive(['d', 'a', 'b', 'e']) == sorted(['d', 'a', 'b', 'e'])
-    True
-    >>> bubble_sort_recursive(['z', 'a', 'y', 'b', 'x', 'c'])
-    ['a', 'b', 'c', 'x', 'y', 'z']
-    >>> bubble_sort_recursive([1.1, 3.3, 5.5, 7.7, 2.2, 4.4, 6.6])
-    [1.1, 2.2, 3.3, 4.4, 5.5, 6.6, 7.7]
-    >>> bubble_sort_recursive([1, 3.3, 5, 7.7, 2, 4.4, 6])
-    [1, 2, 3.3, 4.4, 5, 6, 7.7]
-    >>> bubble_sort_recursive(['a', 'Z', 'B', 'C', 'A', 'c'])
-    ['A', 'B', 'C', 'Z', 'a', 'c']
-    >>> import random
-    >>> collection_arg = random.sample(range(-50, 50), 100)
-    >>> bubble_sort_recursive(collection_arg) == sorted(collection_arg)
-    True
-    >>> import string
-    >>> collection_arg = random.choices(string.ascii_letters + string.digits, k=100)
-    >>> bubble_sort_recursive(collection_arg) == sorted(collection_arg)
-    True
+def bubble_sort_optimized(collection: list[Any]) -> list[Any]:
+    """
+    Optimized Bubble Sort
+
+    Uses the last swap position to reduce unnecessary comparisons
+    when part of the list is already sorted.
+
+    :param collection: A mutable list of comparable elements
+    :return: Sorted list
     """
-    length = len(collection)
-    swapped = False
-    for i in range(length - 1):
-        if collection[i] > collection[i + 1]:
-            collection[i], collection[i + 1] = collection[i + 1], collection[i]
-            swapped = True
-
-    return collection if not swapped else bubble_sort_recursive(collection)
-
-
-if __name__ == "__main__":
-    import doctest
-    from random import sample
-    from timeit import timeit
-
-    doctest.testmod()
-
-    # Benchmark: Iterative seems slightly faster than recursive.
-    num_runs = 10_000
-    unsorted = sample(range(-50, 50), 100)
-    timer_iterative = timeit(
-        "bubble_sort_iterative(unsorted[:])", globals=globals(), number=num_runs
-    )
-    print("\nIterative bubble sort:")
-    print(*bubble_sort_iterative(unsorted), sep=",")
-    print(f"Processing time (iterative): {timer_iterative:.5f}s for {num_runs:,} runs")
-
-    unsorted = sample(range(-50, 50), 100)
-    timer_recursive = timeit(
-        "bubble_sort_recursive(unsorted[:])", globals=globals(), number=num_runs
-    )
-    print("\nRecursive bubble sort:")
-    print(*bubble_sort_recursive(unsorted), sep=",")
-    print(f"Processing time (recursive): {timer_recursive:.5f}s for {num_runs:,} runs")
+
+    n = len(collection)
+    if n < 2:
+        return collection
+
+    while n > 1:
+        last_swap = 0
+        for i in range(1, n):
+            if collection[i - 1] > collection[i]:
+                collection[i - 1], collection[i] = collection[i], collection[i - 1]
+                last_swap = i
+        n = last_swap
+
+    return collection