-
-
Notifications
You must be signed in to change notification settings - Fork 1
C++ review #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
C++ review #5
Changes from all commits
Commits
Show all changes
39 commits
Select commit
Hold shift + click to select a range
14d3d2b
feat: implement kernel management architecture including SPK facade, …
TheDaniel166 1927f66
docs: add LLM documentation indices and update README with visibility…
TheDaniel166 c15f11f
refactor: introduce CoreFacadeMixin and constants library to modulari…
TheDaniel166 af04ce7
chore: bump version to 3.0.0 and update release documentation
TheDaniel166 27072b1
docs: add Harmograms to capabilities list
TheDaniel166 d37970d
feat: implement core astronomy facade mixins and add example Flask we…
TheDaniel166 b0908b9
docs: add architecture specification for dual-substrate Python/C++ na…
TheDaniel166 e0f9857
c++ backend
TheDaniel166 cfc491f
c++ backend
TheDaniel166 33b35eb
repo clean up and planning
TheDaniel166 260fbed
c++ parity to python optimazation
TheDaniel166 9abafad
more c++ work and benchmarking
TheDaniel166 178a812
asteriod corrections
TheDaniel166 de39f3e
polar motion work
TheDaniel166 b316d25
lunar linb c++ work
TheDaniel166 2ea5711
packaging correction
TheDaniel166 1724ff5
Release 3.1.0
TheDaniel166 4a7b593
Helical c++
TheDaniel166 3cba7c5
added Transit search c++
TheDaniel166 d7a13e5
docs: add feature audit design spec — 12 domains, 8 competitors, P1/P…
TheDaniel166 8fc17b8
docs: add feature audit implementation plan — 17 tasks, 12 domains, 8…
TheDaniel166 ccebe43
audit: create FEATURE_AUDIT_2026 skeleton
TheDaniel166 3311f24
audit: domain 1 — body coverage matrix complete
TheDaniel166 d55b88a
audit: domain 2 — house systems matrix complete
TheDaniel166 556b200
audit: domain 3 — aspects matrix complete
TheDaniel166 899177c
audit: domain 4 — dignities matrix complete
TheDaniel166 f605f30
audit: domain 5 — lots and special points matrix complete
TheDaniel166 6407a9c
audit: domain 6 — transits and returns matrix complete
TheDaniel166 dc7c49b
audit: domain 7 — progressions and directions matrix complete
TheDaniel166 472c66e
audit: domain 8 — time lord systems matrix complete
TheDaniel166 f8a4c2e
cleanup of lola.cpp
TheDaniel166 e6ee1e5
audit: domain 9 — synastry matrix complete
TheDaniel166 ac44bcd
audit: domain 10 — phenomena matrix complete
TheDaniel166 9010528
audit: domain 11 — astrocartography matrix complete
TheDaniel166 600b1bd
closing gaps with other software work
TheDaniel166 2012f59
fixed github job failure
TheDaniel166 269155a
eclipse testing
TheDaniel166 0125234
fix: make moira_native import optional in transits modules
TheDaniel166 adb5b2b
I fixed moira/timelords.py (line 1201) by turning the forward referen…
TheDaniel166 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| # Changelog | ||
|
|
||
| All notable changes to the Moira project will be documented in this file. | ||
|
|
||
| The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), | ||
| and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). | ||
|
|
||
| ## [2.2.0] - 2026-05-04 | ||
|
|
||
| ### Added | ||
| - **Sovereign Star Registry**: Full implementation of a license-independent, Gaia DR3-anchored registry of 1,809 named stars with sub-arcsecond epoch propagation. | ||
| - **Harmograms Engine**: Mathematically explicit research engine for planetary intensity spectra (Strata H1-H5), including zero-Aries parts and spectral projection. | ||
| - **Astrocartography (ACG)**: Planetary lines (MC, IC, ASC, DSC) and zenith-nadir calculations with full topocentric support. | ||
| - **Multiple Star Systems**: Keplerian orbital mechanics for visually resolvable binaries (Sirius AB, Alpha Centauri AB) across VISUAL, WIDE, SPECTROSCOPIC, and OPTICAL types. | ||
| - **Solar/Lunar Eclipse Cartography**: Besselian sample-based shadow band and contour extraction. | ||
| - **Void of Course Moon**: Integrated window detection and last-aspect analysis. | ||
| - **Jones Chart Shapes**: Automatic temperament type classification (all 7 Jones shapes). | ||
|
|
||
| ### Changed | ||
| - **Facade Refactor**: Introduced `CoreFacadeMixin` and a unified constants library to modularize astronomical calculations. | ||
| - **Registry Performance**: Optimized star lookup speeds through binary-mapped substrate headers. | ||
|
|
||
| ## [2.1.0] - 2026-04-16 | ||
|
|
||
| ### Added | ||
| - **Traditional Dignities**: Complete Hellenistic and Medieval dignity suite including Sect, Hayz, Domicile, Exaltation, Triplicity, Terms, and Face. | ||
| - **Predictive Techniques**: High-fidelity implementations of Firdaria, Zodiacal Releasing (Valens method), and Annual/Monthly Profections. | ||
| - **Vedic Suite**: Comprehensive Jyotish tools including Vimshottari Dasha, Varga/divisional charts (D9, D10, D12, etc.), Shadbala, Ashtakavarga, and Panchanga. | ||
| - **Longevity Engine**: Hyleg and Alcocoden calculation with explicit planetary condition profiling. | ||
| - **Ayanamsa Systems**: Implementation of 40+ sidereal systems including star-anchored "True" ayanamsas. | ||
| - **Primary Directions**: Placidus semi-arc and mundane directions with speculum computation. | ||
| - **Heliacal Phenomena**: General visibility surface (V5) for rising/setting, acronychal events, and lunar crescent visibility. | ||
| - **Fixed Star Lore**: Integration of 499 Arabic Parts (Lots) and 36 Hermetic decans with ruling stars. | ||
|
|
||
| ## [2.0.0] - 2026-04-10 | ||
|
|
||
| ### Added | ||
| - **Phase α Accuracy Certification**: Transition to a sub-arcsecond accurate substrate grounded in IAU ERFA/SOFA standards. | ||
| - **JPL DE441 Support**: Integration of high-precision long-term planetary ephemerides. | ||
| - **IAU 2006 Standards**: Implementation of the full IAU 2000A/2006 precession and nutation models. | ||
| - **Relativistic Reduction Pipeline**: Geometric positions corrected for light-time, gravitational deflection, annual aberration, and frame bias. | ||
| - **Unified Facade**: Introduction of the `Moira` class and `Chart` objects as the stable public surface. | ||
|
|
||
| ## [1.0.0] - 2026-04-01 | ||
|
|
||
| ### Added | ||
| - **Initial Stable Release**: Core planetary positions, house systems (17 systems), and zodiacal aspects. | ||
| - **Kernel Management**: Integrated CLI and GUI tools for JPL kernel acquisition and configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,69 @@ | ||
| # Moira Asteroid Kernel Cleanup - Complete | ||
|
|
||
| ## Date | ||
| 2026-05-09 | ||
|
|
||
| ## What Was Done | ||
| Removed corrupted shards 16 and 18 from the Type 13 asteroid kernel collection due to Horizons API chunking discontinuities. | ||
|
|
||
| ## Final State | ||
|
|
||
| ### ✅ Working Shards: 1-15, 17 | ||
| - **Total bodies**: 378 | ||
| - **Coverage**: 1500-2500 CE (1000 years) | ||
| - **Precision**: Sub-nanometer (max_node_error < 3e-8 km) | ||
| - **Source**: Official JPL kernels (reliable) | ||
|
|
||
| ### Shard Breakdown | ||
| | Shard | Bodies | Source | Status | | ||
| |-------|--------|--------|--------| | ||
| | 1-15 | 372 | sb441-n373s.bsp | ✅ Working | | ||
| | 16 | 6 | Horizons API | ❌ Removed (corrupted) | | ||
| | 17 | 6 | centaurs.bsp | ✅ Working | | ||
| | 18 | 5 | Horizons API | ❌ Removed (corrupted) | | ||
|
|
||
| ### Bodies Removed (11 total) | ||
| **Shard 16 - Asteroids:** | ||
| - Pandora, Persephone, Amor, Icarus, Apollo, Karma | ||
|
|
||
| **Shard 18 - Comets:** | ||
| - Halley, Encke, Tempel 1, C-G, Swift-Tuttle | ||
|
|
||
| ## Files Removed | ||
| - `kernels/sb441_type13/sb441_type13_shard_016.bsp` | ||
| - `kernels/sb441_type13/sb441_type13_shard_018.bsp` | ||
| - `scripts/rebuild_shard_16.py` | ||
| - `scripts/rebuild_shard_18.py` | ||
|
|
||
| ## Files Modified | ||
| - `kernels/sb441_type13/manifest.json` (updated body count and removed shard entries) | ||
|
|
||
| ## Why This Happened | ||
| JPL Horizons API returns **inconsistent numerical integrations** when the same body is queried with different time spans. When building shards 16 and 18, the chunked fetching (400-year chunks) caused: | ||
| - **43 million km discontinuities** at chunk boundaries | ||
| - **Kernel file corruption** (unreadable by jplephem) | ||
| - **Silent data corruption** that would have produced wrong astronomical positions | ||
|
|
||
| ## Why Shard 17 Survived | ||
| Shard 17 was converted from the official `centaurs.bsp` kernel (not Horizons API), so it has no chunking issues. | ||
|
|
||
| ## Impact on Users | ||
| - ✅ **378 reliable bodies** with millennial coverage | ||
| - ❌ **11 bodies unavailable** (will error if queried) | ||
| - ✅ **Honest failure** instead of silent corruption | ||
| - ✅ **Astronomical truth preserved** | ||
|
|
||
| ## Verification | ||
| All remaining shards have been validated: | ||
| - Type 13 (Hermite interpolation) ✅ | ||
| - 1000-year coverage (1500-2500) ✅ | ||
| - Sub-nanometer precision ✅ | ||
| - No discontinuities ✅ | ||
|
|
||
| ## Recommendation | ||
| This is the correct state. Do not attempt to rebuild shards 16 or 18 from Horizons unless: | ||
| 1. JPL releases official kernels for these bodies | ||
| 2. You restrict to observational coverage only (no millennial extrapolation) | ||
| 3. You implement and validate discontinuity detection | ||
|
|
||
| **Astronomical truth first. Always.** |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| cmake_minimum_required(VERSION 3.12) | ||
| project(moira_native LANGUAGES CXX) | ||
|
|
||
| set(CMAKE_CXX_STANDARD 17) | ||
| set(CMAKE_CXX_STANDARD_REQUIRED ON) | ||
|
|
||
| # Explicitly include Python and pybind11 directories to bypass config failures | ||
| include_directories("C:/Python314/Include") | ||
| include_directories("C:/Users/nilad/AppData/Roaming/Python/Python314/site-packages/pybind11/include") | ||
| include_directories(src/native/include) | ||
|
|
||
| # Define the extension module manually under a private backend name. | ||
| add_library(_moira_native MODULE | ||
| src/native/bindings/moira_native.cpp | ||
| src/native/src/lola.cpp | ||
| ) | ||
|
|
||
| # Link against Python library | ||
| target_link_libraries(_moira_native PRIVATE "C:/Python314/libs/python314.lib") | ||
|
|
||
| # Set target properties to match Python's extension requirements | ||
| set_target_properties(_moira_native PROPERTIES | ||
| PREFIX "" | ||
| SUFFIX ".pyd" | ||
| OUTPUT_NAME "_moira_native" | ||
| LIBRARY_OUTPUT_DIRECTORY "${CMAKE_SOURCE_DIR}/moira" | ||
| RUNTIME_OUTPUT_DIRECTORY "${CMAKE_SOURCE_DIR}/moira" | ||
| LIBRARY_OUTPUT_DIRECTORY_RELEASE "${CMAKE_SOURCE_DIR}/moira" | ||
| RUNTIME_OUTPUT_DIRECTORY_RELEASE "${CMAKE_SOURCE_DIR}/moira" | ||
| LIBRARY_OUTPUT_DIRECTORY_DEBUG "${CMAKE_SOURCE_DIR}/moira" | ||
| RUNTIME_OUTPUT_DIRECTORY_DEBUG "${CMAKE_SOURCE_DIR}/moira" | ||
| CXX_VISIBILITY_PRESET hidden | ||
| VISIBILITY_INLINES_HIDDEN ON | ||
| ) | ||
|
|
||
| # Installation (optional for now, we'll build in place) | ||
| install(TARGETS _moira_native DESTINATION moira) | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1. Hardcoded windows cmake paths
🐞 Bug☼ ReliabilityAgent Prompt
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools