Accept Cargo-owned Windows hardlinks - #1620
Merged
TheGreenCedar merged 1 commit intoJul 30, 2026
Merged
Conversation
TheGreenCedar
marked this pull request as ready for review
July 30, 2026 12:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
The exact-head Windows package job in run 30537929769 completed its single release Cargo graph in 20m17s, then rejected the first CLI executable because the selector required every output to have one native link. Cargo deliberately builds local MSVC binaries under release/deps and hardlinks the user-facing copy into the release root.
Base: b0e9250
Reviewed head: ef17d6e
What changed
No workflow job or claim edge changed, so workflow policy and release-claims.json are intentionally unchanged.
Independent attack
A live Windows Cargo probe disproved the first same-basename implementation: cargo-hardlink-probe.exe is linked to deps/cargo_hardlink_probe.exe. The reviewed head uses Cargo's hyphen-to-underscore normalization.
The verifier then rejected:
Verification
No broad source or package proof was rerun, and the failed 04605eb head will not be rerun.
Closes #1618