Fixed the S/R version of nth_element with unit test added#6720
Open
sususu5 wants to merge 3 commits intoTheHPXProject:masterfrom
Open
Fixed the S/R version of nth_element with unit test added#6720sususu5 wants to merge 3 commits intoTheHPXProject:masterfrom
sususu5 wants to merge 3 commits intoTheHPXProject:masterfrom
Conversation
|
Can one of the admins verify this patch? |
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesFootnotes
|
c13ac23 to
330b2ea
Compare
Signed-off-by: David Hua <z5529749@ad.unsw.edu.au>
Signed-off-by: David Hua <z5529749@ad.unsw.edu.au>
Signed-off-by: David Hua <z5529749@ad.unsw.edu.au>
330b2ea to
8d80ae8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #
Proposed Changes
Any background context you want to provide?
URL of the removed line in unit test
https://github.com/STEllAR-GROUP/hpx/blob/1dcd2571f809830809a7f9d4ecdce7f2b555ca2e/libs/core/algorithms/tests/unit/algorithms/nth_element_sender.cpp#L90
Checklist
Not all points below apply to all pull requests.