Skip to content

Fixed the managed to unmanaged change#6954

Open
nischitkumar wants to merge 2 commits intoTheHPXProject:masterfrom
nischitkumar:master
Open

Fixed the managed to unmanaged change#6954
nischitkumar wants to merge 2 commits intoTheHPXProject:masterfrom
nischitkumar:master

Conversation

@nischitkumar
Copy link
Copy Markdown

Fixes #6953

Proposed Changes

Implemented the one word fix (managed->unmanaged). This was necessary because base_component::get_unmanaged_id returns an hpx::id_type tagged with management_type::managed instead of management_type::unmanaged. When the returned ID is serialized to a remote locality, this triggers an assertion failure in credit_handling.cpp in debug builds.

@nischitkumar nischitkumar requested a review from hkaiser as a code owner March 1, 2026 06:16
@StellarBot
Copy link
Copy Markdown

Can one of the admins verify this patch?

Signed-off-by: nischitkumar <nischitkumar@gmail.com>
Copy link
Copy Markdown
Contributor

@hkaiser hkaiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add a test that reproduces the issue and demonstrates that the issue is fixed by your PR?

@hkaiser
Copy link
Copy Markdown
Contributor

hkaiser commented Mar 8, 2026

@nischitkumar Would you have the time to finish this PR?

@hkaiser
Copy link
Copy Markdown
Contributor

hkaiser commented Mar 14, 2026

@nischitkumar Would you have the time to finish this PR?

Ping? Do you have any plans to wrap this up? Do you need help?

@nischitkumar
Copy link
Copy Markdown
Author

Hey @hkaiser, apologies for the delay in getting back, I'd been tied up with my university exams. I shall resume working on the PR and shall find relevant test cases. Shall definitely ping you if I run into any issues.

@hkaiser
Copy link
Copy Markdown
Contributor

hkaiser commented Mar 23, 2026

@nischitkumar Do you still plan to work on this PR? I believe your proposed change is valid, so all we need to prove that it is would be a test that exercises the modified code path, thus showing that a problem that was there before is now gone.

@codacy-production
Copy link
Copy Markdown

codacy-production bot commented Apr 3, 2026

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

TIP This summary will be updated as you push new changes. Give us feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

base_component::get_unmanaged_id incorrectly returns management_type::managed ID

3 participants