Fixed the managed to unmanaged change#6954
Fixed the managed to unmanaged change#6954nischitkumar wants to merge 2 commits intoTheHPXProject:masterfrom
Conversation
|
Can one of the admins verify this patch? |
Signed-off-by: nischitkumar <nischitkumar@gmail.com>
hkaiser
left a comment
There was a problem hiding this comment.
Could you please add a test that reproduces the issue and demonstrates that the issue is fixed by your PR?
|
@nischitkumar Would you have the time to finish this PR? |
Ping? Do you have any plans to wrap this up? Do you need help? |
|
Hey @hkaiser, apologies for the delay in getting back, I'd been tied up with my university exams. I shall resume working on the PR and shall find relevant test cases. Shall definitely ping you if I run into any issues. |
|
@nischitkumar Do you still plan to work on this PR? I believe your proposed change is valid, so all we need to prove that it is would be a test that exercises the modified code path, thus showing that a problem that was there before is now gone. |
Up to standards ✅🟢 Issues
|
Fixes #6953
Proposed Changes
Implemented the one word fix (managed->unmanaged). This was necessary because base_component::get_unmanaged_id returns an hpx::id_type tagged with management_type::managed instead of management_type::unmanaged. When the returned ID is serialized to a remote locality, this triggers an assertion failure in credit_handling.cpp in debug builds.