Add unit tests for hierarchical all_reduce and all_gather#7189
Merged
hkaiser merged 3 commits intoTheHPXProject:masterfrom Apr 16, 2026
Merged
Add unit tests for hierarchical all_reduce and all_gather#7189hkaiser merged 3 commits intoTheHPXProject:masterfrom
hkaiser merged 3 commits intoTheHPXProject:masterfrom
Conversation
Tests verify correctness of the reduce+broadcast and gather+broadcast compositions at varying site counts (2-64) and arities (2, 4, 8, 16). Both local (single-locality, multi-threaded) and distributed (multi-locality) configurations are covered.
Up to standards ✅🟢 Issues
|
|
Can one of the admins verify this patch? |
hkaiser
reviewed
Apr 15, 2026
Signed-off-by: iemAnshuman <asquare567@gmail.com>
Contributor
Author
|
@hkaiser CMakeLists sorting fixed per your review. All CI green. Ready for re-review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests verify correctness of the reduce+broadcast and gather+broadcast compositions at varying site counts (2-64) and arities (2, 4, 8, 16). Both local (single-locality, multi-threaded) and distributed (multi-locality) configurations are covered.
Follows the same pattern as the existing
reduce_hierarchical,gather_hierarchical,broadcast_hierarchical, andscatter_hierarchicaltests.Companion to #7160 which added the hierarchical all_reduce and all_gather implementations.
Proposed Changes
all_reduce_hierarchical.cppunit testall_gather_hierarchical.cppunit testCMakeLists.txtunder the networking test suiteAny background context you want to provide?
The hierarchical all_reduce and all_gather were merged in #7160 but without dedicated unit tests. These tests fill that gap.
Checklist