Skip to content

fix: ping width extends into names or scoreboard #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TheKodeToad merged 2 commits into from
Nov 6, 2025
Merged

fix: ping width extends into names or scoreboard #25

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1963ad5
fix: ping width extends into names or scoreboard
JustAlittleWolf Jul 2, 2025
5b26019
fix: forgot to call original Math.min function
JustAlittleWolf Jul 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions src/main/java/io/toadlabs/numeralping/mixin/PlayerListHudMixin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
package io.toadlabs.numeralping.mixin;

import com.llamalad7.mixinextras.injector.wrapoperation.Operation;
import com.llamalad7.mixinextras.injector.wrapoperation.WrapOperation;
import com.llamalad7.mixinextras.sugar.Local;
import org.spongepowered.asm.mixin.*;
import org.spongepowered.asm.mixin.injection.*;
import org.spongepowered.asm.mixin.injection.callback.CallbackInfo;
Expand All @@ -11,9 +14,27 @@
import net.minecraft.client.gui.hud.PlayerListHud;
import net.minecraft.client.network.PlayerListEntry;

import java.util.List;

@Mixin(PlayerListHud.class)
public class PlayerListHudMixin {

@WrapOperation(method = "render", at = @At(value = "INVOKE", target = "Ljava/lang/Math;min(II)I", ordinal = 0))
private int adjustTablistEntryWidth(int a, int b, Operation<Integer> original, @Local(ordinal = 0) List<PlayerListEntry> playerListEntries) {
NumeralConfig config = NumeralConfig.instance();
int vanillaPingWidth = 9;
int maxPingWidth = vanillaPingWidth;

for (PlayerListEntry playerListEntry : playerListEntries) {
String pingString = Integer.toString(playerListEntry.getLatency());
pingString = config.shiftPing(pingString);

maxPingWidth = Math.max(maxPingWidth, client.textRenderer.getWidth(pingString));
}

return original.call(a + maxPingWidth - vanillaPingWidth, b);
}

@Inject(method = "renderLatencyIcon", at = @At("HEAD"), cancellable = true)
public void renderDetailedLatency(DrawContext context, int width, int x, int y, PlayerListEntry entry,
CallbackInfo callback) {
Expand Down
Loading