feat: allow custom ping string format#27
Open
JustAlittleWolf wants to merge 6 commits intoTheKodeToad:mainfrom
Open
feat: allow custom ping string format#27JustAlittleWolf wants to merge 6 commits intoTheKodeToad:mainfrom
JustAlittleWolf wants to merge 6 commits intoTheKodeToad:mainfrom
Conversation
This allows for custom formats like "%pms" which would be displayed as "10ms" for a ping of 10 milliseconds. - added a static Utils.getPingText method to get the ping text of a given latency - moved `shiftPing` from the NumeralConfig to the Utils class - added yacl config options for configuring the format of the ping string. The placeholder %p can be used to reference the numeric ping value
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows for custom formats like "%pms" which would be displayed as "10ms" for a ping of 10 milliseconds.
shiftPingfrom the NumeralConfig to the Utils classAs is the custom format would most likely intersect with player names, which looks bad. #25 would fix this issue. This PR is marked as a draft until #25 is merged, as the tablist width logic needs adjusting to match the new ping format of this PR.