Skip to content

feat: Get certificate by instructor#156

Merged
thanglp163 merged 1 commit intodevfrom
feature/task-certificate_thang
Aug 23, 2025
Merged

feat: Get certificate by instructor#156
thanglp163 merged 1 commit intodevfrom
feature/task-certificate_thang

Conversation

@thanglp163
Copy link
Copy Markdown
Collaborator

@thanglp163 thanglp163 commented Aug 23, 2025

Summary by CodeRabbit

  • New Features
    • Added an endpoint for instructors to retrieve certificates associated with their courses.
    • Results include learner and course details and are sorted by newest first.
    • Returns an empty list when no certificates are found.
    • Requires authentication and instructor role to access.
    • Provides clear responses for unauthorized access and server errors.

@thanglp163 thanglp163 self-assigned this Aug 23, 2025
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Aug 23, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

Adds a new instructor-only GET endpoint to list certificates for courses authored by the authenticated user. Implements controller logic to query courses by authorId, fetch related certificates with selected populations, sort by creation date, and handle auth, empty results, and errors. Updates routing to wire the endpoint with middlewares.

Changes

Cohort / File(s) Summary
Instructor certificates endpoint
src/routes/certificate.route.ts
Adds GET /instructor/courses route protected by isAuthenticated and authorizeRoles('instructor'), invoking getCertificatesByInstructor. Updates imports and adds a descriptive comment.
Controller for instructor certificates
src/controllers/certificate.controller.ts
Adds getCertificatesByInstructor(req, res): validates req.user._id, queries Course by authorId, fetches and populates matching Certificate records, sorts by createdAt desc, returns results; handles 401 and 500 cases.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  actor U as Instructor (Client)
  participant R as Router: /certificates
  participant A as isAuthenticated
  participant AR as authorizeRoles("instructor")
  participant C as certificate.controller.getCertificatesByInstructor
  participant M1 as Course Model
  participant M2 as Certificate Model

  U->>R: GET /instructor/courses
  R->>A: Verify session/JWT
  A-->>R: OK or 401
  alt Unauthenticated
    R-->>U: 401 Unauthorized
  else Authenticated
    R->>AR: Check role = instructor
    AR-->>R: OK or 403
    alt Not instructor
      R-->>U: 403 Forbidden
    else Instructor
      R->>C: getCertificatesByInstructor(req, res)
      C->>M1: find({ authorId: req.user._id }).select("_id")
      M1-->>C: courseIds
      alt No courses
        C-->>U: 200 []
      else Has courses
        C->>M2: find({ course: { $in: courseIds }})<br/>.populate(user, course)<br/>.sort(-createdAt)
        M2-->>C: certificates
        C-->>U: 200 certificates
      end
    end
  end

  rect rgba(200, 230, 255, 0.3)
    note right of C: New controller flow to aggregate certificates by instructor-owned courses
  end
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10–15 minutes

Possibly related PRs

  • feat: api Certificate #47 — Adds certificate controllers/routes; overlaps with controller and routing areas touched here.
  • Feature/task 46 #48 — Further certificate controller/route additions; likely adjacent to the new instructor-specific endpoint.

Poem

I thump my paws on verdant ground,
New routes hop in without a sound—
Instructor trails to certs now clear,
Courses gathered, proofs appear.
With tidy paws, I fetch and sort,
200s bloom—a happy report. 🐇✨

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.


📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 4302341 and 66fef9a.

📒 Files selected for processing (2)
  • src/controllers/certificate.controller.ts (1 hunks)
  • src/routes/certificate.route.ts (2 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feature/task-certificate_thang

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@thanglp163 thanglp163 merged commit c223d31 into dev Aug 23, 2025
2 of 3 checks passed
@thanglp163 thanglp163 deleted the feature/task-certificate_thang branch August 24, 2025 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant