Feature/task 132 vi

[theqi106]

Summary by CodeRabbit

• New Features
  • Admin users now see business-specific discounts in the discounts list when their account is associated with a business. This improves discovery and management of promotions within the admin experience, ensuring admins can access all discounts relevant to their organization. No changes to permissions for other roles.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

Adds role-aware filtering in getAvailableDiscounts: when the requester is an admin and a businessId is provided, the query includes discounts matching that businessId (cast to ObjectId). Other edits are whitespace/formatting only. No public API signatures changed.

Changes

Cohort / File(s)	Summary
Discount retrieval logic src/controllers/discount.controller.ts	Updated getAvailableDiscounts to read req.user?.businessInfo?.role and, for admin users with a businessId, add a businessId ObjectId filter to the discounts query. Other edits are formatting-only.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  actor User
  participant API as Controller:getAvailableDiscounts
  participant DB as Discounts Collection

  User->>API: GET /discounts?businessId=...
  API->>API: Read req.user.businessInfo.role
  alt role == 'admin' and businessId present
    API->>API: Build query with { businessId: ObjectId(businessId), ... }
  else
    API->>API: Build query without businessId constraint
  end
  API->>DB: find(query)
  DB-->>API: discounts[]
  API-->>User: 200 OK + discounts

Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

• fix: fix create discount #151 — Adjusts discount creation fields (allowedBusinesses/allowedUsers), directly related to how retrieval filters may interact.
• feat: add get available volcher #93 — Modifies getAvailableDiscounts; closely related to current admin/businessId filtering changes.
• fix: fix lose func #104 — Introduces getAvailableDiscounts; current PR refines its filtering logic.

Poem

I nibble through code with a carrot-shaped pen,
Hop-hop, I filter for business IDs again.
Admins get a tunnel to their own deals,
While whitespace tidies up the wheels.
Discounts fetched, the burrow’s bright—
Query hops true, results take flight. 🥕✨

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between c223d31 and 557d0e3.

📒 Files selected for processing (1)

• src/controllers/discount.controller.ts (8 hunks)

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch feature/task-132_vi

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

• Visit our Status Page to check the current availability of CodeRabbit.
• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.