Skip to content

Feature/task hotfix anh1#164

Merged
anhlnp merged 4 commits intodevfrom
feature/task-hotfix_anh1
Aug 29, 2025
Merged

Feature/task hotfix anh1#164
anhlnp merged 4 commits intodevfrom
feature/task-hotfix_anh1

Conversation

@anhlnp
Copy link
Copy Markdown
Collaborator

@anhlnp anhlnp commented Aug 29, 2025

Summary by CodeRabbit

  • New Features

    • Course lists now include a rating count for each course.
  • Bug Fixes

    • More reliable logout behavior across environments with improved cookie clearing.
    • Reduced CORS-related errors: supports requests without Origin (e.g., mobile/cURL) and localhost in non-production.
    • Preflight (OPTIONS) requests handled correctly; improved header compatibility.
  • Chores

    • Expanded CORS configuration (methods, allowed/exposed headers) to improve session and cookie interoperability.
    • Standardized token cookie options for better cross-environment consistency.

@vercel
Copy link
Copy Markdown

vercel bot commented Aug 29, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
neurolearn-backend Ready Ready Preview Comment Aug 29, 2025 5:30am

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Aug 29, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

Updates adjust CORS behavior in app.ts, add ratingCount to course listing responses, refine logout cookie-clearing flags, and extend JWT cookie option types to include an optional domain.

Changes

Cohort / File(s) Summary of changes
CORS configuration and origin handling
src/app.ts
Expanded CORS: handle no-origin requests; allow listed origins; allow localhost in non-prod; log and reject blocked origins. Methods include OPTIONS; headers include X-Requested-With; exposes Set-Cookie.
Course top endpoints response shape
src/controllers/course.controller.ts
Added ratingCount to each course in getTopCourses and getTopViewing, computed from reviews length; no data retrieval or control flow changes.
Logout cookie clearing behavior
src/controllers/user.controller.ts
Updated cookie clearing for access_token and refresh_token: env-dependent secure and sameSite, added path '/', removed fixed domain.
JWT token cookie options domain support
src/utils/jwt.ts
ITokenOptions now includes optional domain. accessTokenOptions and refreshTokenOptions include domain (undefined), with minor syntax updates.

Sequence Diagram(s)

sequenceDiagram
    autonumber
    participant C as Client
    participant S as Server (Express)
    participant M as CORS Middleware
    participant Ctrl as Controller

    Note over C,S: Simple request or preflight (OPTIONS)

    C->>S: HTTP Request (with/without Origin)
    S->>M: Validate Origin, Method, Headers
    alt Allowed Origin / No Origin / Dev localhost
        M-->>S: CORS headers set (incl. Set-Cookie exposed)
        opt Preflight (OPTIONS)
            S-->>C: 204/200 with CORS allow headers
        end
        C->>S: Actual request
        S->>Ctrl: Route handler
        Ctrl-->>S: Response
        S-->>C: Response with CORS headers
    else Blocked Origin
        M-->>S: Error "Not allowed by CORS" (logged)
        S-->>C: 403/Error
    end
Loading
sequenceDiagram
    autonumber
    participant C as Client
    participant S as Server (logoutUser)
    Note over S: Cookie flags depend on NODE_ENV

    C->>S: POST /logout
    S->>S: Clear access_token (path=/, secure=prod, sameSite=none in prod, lax otherwise)
    S->>S: Clear refresh_token (same flags)
    S-->>C: 200 Logged out
Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

  • fix: auth #146 — Also modifies src/utils/jwt.ts cookie option attributes, including environment-dependent flags and domain handling.
  • Feature/task 85 anh #86 — Touches src/controllers/course.controller.ts, changing getTopCourses output fields (related to this PR’s response shape adjustments).
  • fix: fix review course api #109 — Updates getTopCourses/getTopViewing responses in course.controller, overlapping with this PR’s additions.

Poem

A hop, a skip, through CORS-y air,
I sniff the headers—handled with care.
Stars for ratings, cookies set free,
Domain optional, as it should be.
With tidy exits and routes that sing,
I thump my paw—ship this thing! 🐇✨

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.


📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 1daf32c and dd251ab.

📒 Files selected for processing (4)
  • src/app.ts (1 hunks)
  • src/controllers/course.controller.ts (2 hunks)
  • src/controllers/user.controller.ts (1 hunks)
  • src/utils/jwt.ts (3 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feature/task-hotfix_anh1

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbit in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbit in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbit gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbit read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbit help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbit ignore or @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbit summary or @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbit or @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@anhlnp anhlnp merged commit a21e5ae into dev Aug 29, 2025
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant