This repository was archived by the owner on Jun 11, 2021. It is now read-only.
Open
Conversation
Collaborator
|
I can't run it in visual studio, but in steam. |
Author
|
Since option controls are hardcoded in the CharacterCreationOptionsStageVM constructor, it wouldn't be possible to make a custom stage without remaking a large part of the code, and we can't say how changing the other difficulty options would affect the game in other areas. |
Z3rca
approved these changes
Jun 7, 2021
Collaborator
There was a problem hiding this comment.
after some discussions with Yaroslav I think the current Harmony patch is a good solution. However, when Taleworlds might change their code, we could revisit this problem, and are hopefully then able to solve the problem over method extensions and loading our submodules. Everything else is too much of a hassle for now in my opinion
59ee3f9 to
776d965
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-Checkbox control removed from both campaign creation menu and from campaign menu
-Birth and death are disabled by default