Estimating image size on disk when Docker is wrong#299
Merged
Conversation
…ingle emission per run
… logic, including updates to size estimation and warning messages for clarity
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a workaround in ExegolImage to display a hardcoded size estimate when Docker reports an implausibly small on-disk image size, aiming to avoid misleading output until Docker’s underlying behavior is understood/fixed.
Changes:
- Track Docker’s raw
Size(bytes) separately for sanity-checking. - Introduce per-tag minimum thresholds and estimated sizes (GB) and switch display to an estimate when Docker-reported size is below the minimum.
- Emit a one-time verbose warning when the fallback display is used.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An issue exists on Docker. The disk size of an image is wrong and tends to return ~16GB instead of ~40GB.
To address that we put in place a low limit that, if crossed, replaces the dynamic size (wrong) with an hardcoded estimate. We think it's better to display a rough estimate than continue to rely on Docker that returns something completely off.
We intend to open a Docker issue when we have sufficient intel to understand the behavior and reproduce steps.