Use shlex to quote environment variables#307
Open
Hackndo wants to merge 1 commit into
Open
Conversation
ShutdownRepo
approved these changes
Jun 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When opening a shell on a container with
-e/--env, Exegol builds thedocker execcommand as a single string and runs it throughos.system(), which executes it via/bin/sh. The environment values are interpolated without any quoting:Exegol/exegol/model/ExegolContainer.py
Lines 225 to 228 in bf4f7aa
As soon as an environment value contains a character that is special to the shell, the command breaks.
Reproduction
The ; terminates the docker exec invocation early (so Docker complains about missing arguments), and the remainder of the value is executed by the shell as a separate command.
This can be weaponized like so by executing arbitrary command on the host
Fix
Shell-quote each environment entry with shlex.quote() before building the command string.