feat: fix change when path contains any spaces#128
Open
kutiny wants to merge 1 commit intoThePrimeagen:masterfrom
Open
feat: fix change when path contains any spaces#128kutiny wants to merge 1 commit intoThePrimeagen:masterfrom
kutiny wants to merge 1 commit intoThePrimeagen:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix #114
Despite having folder names with spaces is really abnormal, I saw people complaining about that. So I decided to fix that problem
I don't know the rules if there are for creating PRs
My solution is quite simple, whenever a path is processed from
git worktree listcommand I changed the way it is processed, if there are more than 3 parts (I assume that the path contains at least one space) I join the parts with a space to get the correct path again.Disclaimer: I do not know a lot of lua, I did my best with my knowledge.