fix:🐛 paths not normalized for windows#131
Open
GustavEikaas wants to merge 1 commit intoThePrimeagen:masterfrom
Open
fix:🐛 paths not normalized for windows#131GustavEikaas wants to merge 1 commit intoThePrimeagen:masterfrom
GustavEikaas wants to merge 1 commit intoThePrimeagen:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Running
:lua require("git-worktree").create_worktree("nvim-btw","main","origin")on windows results in an errorThe
has_worktreefunction does not work on windows. When it tries to compare the output fromgit worktree listwith the calculated path for the newly created worktree it does not get a match.After adding some print statements, i see the following.
Reproduce
:lua require("git-worktree").create_worktree("nvim-btw","main","origin")You will recieve the following error message
Additional
My code only normalizes the path but it is worth considering using vims inbuilt api for concatenating paths
The call to
:absolute()seems redundant on windows as it returns an absolute path but perhaps not on linux?