feature: change worktree on all buffers#93
Open
Kasama wants to merge 1 commit intoThePrimeagen:masterfrom
Open
feature: change worktree on all buffers#93Kasama wants to merge 1 commit intoThePrimeagen:masterfrom
Kasama wants to merge 1 commit intoThePrimeagen:masterfrom
Conversation
Change update_current_buffer function to update all currently open buffers and de-list buffers from the previous worktree. Buffers from files that don't exist on another worktree will only be de-listed. Buffers unrelated to the worktree (temporary or external files) should ignored The focused buffer file will be kept focused on the new worktree, unless if it doesn't exist, in which case it will select the last one. In the future, it would also be possible to remember closed files that don't exist for when you switch back, that's not addressed by this PR Also fixes ThePrimeagen#84
Kasama
force-pushed
the
feature/switch-all-buffers
branch
from
fcef103 to
1fc963d
Compare
I don't care for this change, at least if it's forced 100% of the time. It is very useful to be able to open a split and compare the same files across branches, this change would not allow you to do this. I do understand where the motivation for this is coming from, so perhaps there could be an option / different keypress to change all buffers vs. only changing the current buffer |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change update_current_buffer function to update all currently open buffers and de-list buffers from the previous worktree.
Buffers from files that don't exist on another worktree will only be de-listed.
Buffers unrelated to the worktree (temporary or external files) should ignored
The focused buffer file will be kept focused on the new worktree, unless if it doesn't exist, in which case it will select the last one.
In the future, it would also be possible to remember closed files that don't exist for when you switch back, that's not addressed by this PR
Also fixes #84