Skip to content

fix: release fd slot on failed file open #238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
beeget wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: release fd slot on failed file open #238

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/rars/util/SystemIO.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -392,6 +392,7 @@ public static int openFile(String filename, int flags) {
FileIOData.setStreamInUse(fdToUse, inputStream); // Save stream for later use
} catch (FileNotFoundException e) {
fileErrorString = "File " + filename + " not found, open for input.";
FileIOData.close(fdToUse);
retValue = -1;
}
} else if ((flags & O_WRONLY) != 0) // Open for writing only
Expand All @@ -402,6 +403,7 @@ public static int openFile(String filename, int flags) {
FileIOData.setStreamInUse(fdToUse, outputStream); // Save stream for later use
} catch (FileNotFoundException e) {
fileErrorString = "File " + filename + " not found, open for output.";
FileIOData.close(fdToUse);
retValue = -1;
}
}
Expand Down