Svelte front end by sfoale · Pull Request #95 · TheTreasureMap/gwtm

sfoale · 2025-07-15T12:13:01Z

No description provided.

Basic aladin visualisation implementation complete.

Address linting issues.

Add search pointings page. More visualization tweaks. Signed-off-by: Steve Foale <sfoale@lco.global>

Visualization improvements.

Attempting to get visualization centring correct.

Refactor the api into individual services and types.

cmccully · 2026-02-19T19:35:20Z

frontend/coverage/stores/auth.ts.html

+        <script src="../block-navigation.js"></script>
+    </body>
+</html>
+


Missing newline.

cmccully · 2026-02-19T19:36:23Z

frontend/coverage/stores/formStore.ts.html

+<html lang="en">
+
+<head>
+    <title>Code coverage report for stores/formStore.ts</title>


Does this file need to be in the repo? Or is this something we should dynamically generate?

cmccully · 2026-02-19T19:36:42Z

frontend/coverage/stores/formStore.ts.html

+                <span class="quiet">Lines</span>
+                <span class='fraction'>0/352</span>
+            </div>
+


Same comments as previous coverage file.

cmccully · 2026-02-19T19:38:00Z

frontend/coverage/stores/formStore.ts.html

+&nbsp;
+<span class="cstat-no" title="statement not covered" >			if (!isFormValid) {</span>
+<span class="cstat-no" title="statement not covered" >				store.update((state) =&gt; ({</span>
+<span class="cstat-no" title="statement not covered" >					...state,</span>


There is quite a bit of missing coverage here. Is any of it crucial?

cmccully · 2026-02-19T19:38:13Z

frontend/coverage/stores/formStore.ts.html

+        <script src="../block-navigation.js"></script>
+    </body>
+</html>
+


cmccully · 2026-02-19T19:38:34Z

frontend/coverage/stores/index.html

+        <script src="../block-navigation.js"></script>
+    </body>
+</html>
+


cmccully · 2026-02-19T19:38:49Z

frontend/coverage/stores/index.html

+                <span class="quiet">Lines</span>
+                <span class='fraction'>0/506</span>
+            </div>
+


Again. Lots of whitespace.

cmccully · 2026-02-19T19:39:53Z

argocd-config/argocd-config-app.yaml

@@ -0,0 +1,26 @@
+# ArgoCD Application to manage ArgoCD cluster configurations


Does this belong in this repo or do we need a deploy repo?

cmccully · 2026-02-19T19:40:34Z

frontend/coverage/utils/astronomicalCalculations.ts.html

+                <span class="quiet">Statements</span>
+                <span class='fraction'>64/64</span>
+            </div>
+


Same comment as other coverage files.

cmccully · 2026-02-19T19:41:01Z

frontend/coverage/utils/astronomicalCalculations.ts.html

+        <script src="../block-navigation.js"></script>
+    </body>
+</html>
+


cmccully · 2026-02-19T19:41:20Z

frontend/coverage/utils/errorHandling.ts.html

+                <span class='fraction'>194/220</span>
+            </div>
+
+


Same coverage whitespace comment.

cmccully · 2026-02-19T19:41:45Z

frontend/coverage/utils/errorHandling.ts.html

+        <script src="../block-navigation.js"></script>
+    </body>
+</html>
+


cmccully · 2026-02-19T19:43:15Z

frontend/coverage/utils/index.html

@@ -0,0 +1,131 @@
+


Could we host these reports somewhere? Codecov maybe? Could github host these without having the extra code bloat inside the repo?

cmccully · 2026-02-19T19:43:23Z

frontend/coverage/utils/index.html

+                <span class="quiet">Statements</span>
+                <span class='fraction'>258/284</span>
+            </div>
+


Whitespace.

cmccully · 2026-02-19T19:43:38Z

frontend/coverage/utils/index.html

+        <script src="../block-navigation.js"></script>
+    </body>
+</html>
+


cmccully · 2026-02-19T19:44:01Z

frontend/coverage/utils/errorHandling.ts.html

+    <div class='status-line high'></div>
+    <pre><table class="coverage">
+<tr><td class="line-count quiet"><a name='L1'></a><a href='#L1'>1</a>
+<a name='L2'></a><a href='#L2'>2</a>


Functionalize.

cmccully · 2026-02-19T19:44:22Z

frontend/coverage/validation/index.html

+                <span class='fraction'>20/22</span>
+            </div>
+
+


White space.

cmccully · 2026-02-19T19:44:41Z

frontend/coverage/validation/index.html

+        <script src="../block-navigation.js"></script>
+    </body>
+</html>
+


Newline? Maybe there is just whitespace in 116?

cmccully · 2026-02-19T19:44:56Z

frontend/coverage/validation/validators.ts.html

+                <span class='fraction'>125/126</span>
+            </div>
+
+


Whitespace.

cmccully · 2026-02-19T19:45:02Z

frontend/coverage/validation/validators.ts.html

+    <div class='status-line high'></div>
+    <pre><table class="coverage">
+<tr><td class="line-count quiet"><a name='L1'></a><a href='#L1'>1</a>
+<a name='L2'></a><a href='#L2'>2</a>


Functionalize.

cmccully · 2026-02-19T19:45:24Z

frontend/coverage/validation/validators.ts.html

+        <script src="../block-navigation.js"></script>
+    </body>
+</html>
+


cmccully · 2026-02-19T19:46:25Z

frontend/coverage/coverage-final.json

@@ -0,0 +1,6 @@
+{"/home/stevefoale/code/gwtm/frontend/src/lib/stores/auth.ts": {"path":"/home/stevefoale/code/gwtm/frontend/src/lib/stores/auth.ts","all":true,"statementMap":{"0":{"start":{"line":1,"column":0},"end":{"line":1,"column":40}},"1":{"start":{"line":2,"column":0},"end":{"line":2,"column":43}},"2":{"start":{"line":3,"column":0},"end":{"line":3,"column":39}},"3":{"start":{"line":4,"column":0},"end":{"line":4,"column":31}},"4":{"start":{"line":5,"column":0},"end":{"line":5,"column":56}},"22":{"start":{"line":23,"column":0},"end":{"line":23,"column":28}},"23":{"start":{"line":24,"column":0},"end":{"line":24,"column":57}},"24":{"start":{"line":25,"column":0},"end":{"line":25,"column":25}},"25":{"start":{"line":26,"column":0},"end":{"line":26,"column":13}},"26":{"start":{"line":27,"column":0},"end":{"line":27,"column":56}},"27":{"start":{"line":28,"column":0},"end":{"line":28,"column":13}},"28":{"start":{"line":29,"column":0},"end":{"line":29,"column":4}},"31":{"start":{"line":32,"column":0},"end":{"line":32,"column":21}},"32":{"start":{"line":33,"column":0},"end":{"line":33,"column":17}},"33":{"start":{"line":34,"column":0},"end":{"line":34,"column":53}},"34":{"start":{"line":35,"column":0},"end":{"line":35,"column":10}},"35":{"start":{"line":36,"column":0},"end":{"line":36,"column":3}},"37":{"start":{"line":38,"column":0},"end":{"line":38,"column":39}},"38":{"start":{"line":39,"column":0},"end":{"line":39,"column":47}},"40":{"start":{"line":41,"column":0},"end":{"line":41,"column":25}},"41":{"start":{"line":42,"column":0},"end":{"line":42,"column":8}},"42":{"start":{"line":43,"column":0},"end":{"line":43,"column":37}},"43":{"start":{"line":44,"column":0},"end":{"line":44,"column":9}},"44":{"start":{"line":45,"column":0},"end":{"line":45,"column":27}},"45":{"start":{"line":46,"column":0},"end":{"line":46,"column":16}},"46":{"start":{"line":47,"column":0},"end":{"line":47,"column":18}},"47":{"start":{"line":48,"column":0},"end":{"line":48,"column":19}},"48":{"start":{"line":49,"column":0},"end":{"line":49,"column":7}},"49":{"start":{"line":50,"column":0},"end":{"line":50,"column":12}},"51":{"start":{"line":52,"column":0},"end":{"line":52,"column":29}},"52":{"start":{"line":53,"column":0},"end":{"line":53,"column":36}},"53":{"start":{"line":54,"column":0},"end":{"line":54,"column":77}},"54":{"start":{"line":55,"column":0},"end":{"line":55,"column":4}},"55":{"start":{"line":56,"column":0},"end":{"line":56,"column":10}},"57":{"start":{"line":58,"column":0},"end":{"line":58,"column":76}},"58":{"start":{"line":59,"column":0},"end":{"line":59,"column":3}},"59":{"start":{"line":60,"column":0},"end":{"line":60,"column":3}},"61":{"start":{"line":62,"column":0},"end":{"line":62,"column":22}},"62":{"start":{"line":63,"column":0},"end":{"line":63,"column":19}},"63":{"start":{"line":64,"column":0},"end":{"line":64,"column":19}},"64":{"start":{"line":65,"column":0},"end":{"line":65,"column":20}},"65":{"start":{"line":66,"column":0},"end":{"line":66,"column":28}},"66":{"start":{"line":67,"column":0},"end":{"line":67,"column":51}},"67":{"start":{"line":68,"column":0},"end":{"line":68,"column":7}},"68":{"start":{"line":69,"column":0},"end":{"line":69,"column":73}},"70":{"start":{"line":71,"column":0},"end":{"line":71,"column":53}},"71":{"start":{"line":72,"column":0},"end":{"line":72,"column":56}},"74":{"start":{"line":75,"column":0},"end":{"line":75,"column":32}},"75":{"start":{"line":76,"column":0},"end":{"line":76,"column":18}},"76":{"start":{"line":77,"column":0},"end":{"line":77,"column":56}},"77":{"start":{"line":78,"column":0},"end":{"line":78,"column":5}},"79":{"start":{"line":80,"column":0},"end":{"line":80,"column":9}},"80":{"start":{"line":81,"column":0},"end":{"line":81,"column":27}},"81":{"start":{"line":82,"column":0},"end":{"line":82,"column":16}},"82":{"start":{"line":83,"column":0},"end":{"line":83,"column":18}},"83":{"start":{"line":84,"column":0},"end":{"line":84,"column":19}},"84":{"start":{"line":85,"column":0},"end":{"line":85,"column":7}},"86":{"start":{"line":87,"column":0},"end":{"line":87,"column":82}},"87":{"start":{"line":88,"column":0},"end":{"line":88,"column":53}},"88":{"start":{"line":89,"column":0},"end":{"line":89,"column":35}},"89":{"start":{"line":90,"column":0},"end":{"line":90,"column":11}},"90":{"start":{"line":91,"column":0},"end":{"line":91,"column":71}},"91":{"start":{"line":92,"column":0},"end":{"line":92,"column":4}},"92":{"start":{"line":93,"column":0},"end":{"line":93,"column":17}},"93":{"start":{"line":94,"column":0},"end":{"line":94,"column":39}},"94":{"start":{"line":95,"column":0},"end":{"line":95,"column":23}},"95":{"start":{"line":96,"column":0},"end":{"line":96,"column":84}},"96":{"start":{"line":97,"column":0},"end":{"line":97,"column":45}},"97":{"start":{"line":98,"column":0},"end":{"line":98,"column":59}},"98":{"start":{"line":99,"column":0},"end":{"line":99,"column":23}},"99":{"start":{"line":100,"column":0},"end":{"line":100,"column":13}},"100":{"start":{"line":101,"column":0},"end":{"line":101,"column":27}},"101":{"start":{"line":102,"column":0},"end":{"line":102,"column":15}},"102":{"start":{"line":103,"column":0},"end":{"line":103,"column":16}},"103":{"start":{"line":104,"column":0},"end":{"line":104,"column":18}},"104":{"start":{"line":105,"column":0},"end":{"line":105,"column":7}},"105":{"start":{"line":106,"column":0},"end":{"line":106,"column":50}},"106":{"start":{"line":107,"column":0},"end":{"line":107,"column":3}},"107":{"start":{"line":108,"column":0},"end":{"line":108,"column":3}},"109":{"start":{"line":110,"column":0},"end":{"line":110,"column":29}},"110":{"start":{"line":111,"column":0},"end":{"line":111,"column":7}},"112":{"start":{"line":113,"column":0},"end":{"line":113,"column":27}},"113":{"start":{"line":114,"column":0},"end":{"line":114,"column":19}},"115":{"start":{"line":116,"column":0},"end":{"line":116,"column":49}},"116":{"start":{"line":117,"column":0},"end":{"line":117,"column":3}},"119":{"start":{"line":120,"column":0},"end":{"line":120,"column":27}},"120":{"start":{"line":121,"column":0},"end":{"line":121,"column":7}},"121":{"start":{"line":122,"column":0},"end":{"line":122,"column":26}},"122":{"start":{"line":123,"column":0},"end":{"line":123,"column":14}},"123":{"start":{"line":124,"column":0},"end":{"line":124,"column":15}},"124":{"start":{"line":125,"column":0},"end":{"line":125,"column":17}},"125":{"start":{"line":126,"column":0},"end":{"line":126,"column":5}},"126":{"start":{"line":127,"column":0},"end":{"line":127,"column":72}},"127":{"start":{"line":128,"column":0},"end":{"line":128,"column":46}},"128":{"start":{"line":129,"column":0},"end":{"line":129,"column":3}},"130":{"start":{"line":131,"column":0},"end":{"line":131,"column":36}},"136":{"start":{"line":137,"column":0},"end":{"line":137,"column":29}},"137":{"start":{"line":138,"column":0},"end":{"line":138,"column":51}},"138":{"start":{"line":139,"column":0},"end":{"line":139,"column":7}},"139":{"start":{"line":140,"column":0},"end":{"line":140,"column":54}},"142":{"start":{"line":143,"column":0},"end":{"line":143,"column":25}},"143":{"start":{"line":144,"column":0},"end":{"line":144,"column":29}},"144":{"start":{"line":145,"column":0},"end":{"line":145,"column":73}},"146":{"start":{"line":147,"column":0},"end":{"line":147,"column":43}},"147":{"start":{"line":148,"column":0},"end":{"line":148,"column":17}},"148":{"start":{"line":149,"column":0},"end":{"line":149,"column":72}},"149":{"start":{"line":150,"column":0},"end":{"line":150,"column":6}},"151":{"start":{"line":152,"column":0},"end":{"line":152,"column":53}},"152":{"start":{"line":153,"column":0},"end":{"line":153,"column":28}},"153":{"start":{"line":154,"column":0},"end":{"line":154,"column":17}},"154":{"start":{"line":155,"column":0},"end":{"line":155,"column":46}},"157":{"start":{"line":158,"column":0},"end":{"line":158,"column":63}},"159":{"start":{"line":160,"column":0},"end":{"line":160,"column":61}},"160":{"start":{"line":161,"column":0},"end":{"line":161,"column":38}},"166":{"start":{"line":167,"column":0},"end":{"line":167,"column":72}},"167":{"start":{"line":168,"column":0},"end":{"line":168,"column":40}},"168":{"start":{"line":169,"column":0},"end":{"line":169,"column":57}},"169":{"start":{"line":170,"column":0},"end":{"line":170,"column":18}},"170":{"start":{"line":171,"column":0},"end":{"line":171,"column":27}},"171":{"start":{"line":172,"column":0},"end":{"line":172,"column":40}},"173":{"start":{"line":174,"column":0},"end":{"line":174,"column":47}},"175":{"start":{"line":176,"column":0},"end":{"line":176,"column":51}},"176":{"start":{"line":177,"column":0},"end":{"line":177,"column":12}},"177":{"start":{"line":178,"column":0},"end":{"line":178,"column":62}},"178":{"start":{"line":179,"column":0},"end":{"line":179,"column":71}},"179":{"start":{"line":180,"column":0},"end":{"line":180,"column":8}},"180":{"start":{"line":181,"column":0},"end":{"line":181,"column":19}},"181":{"start":{"line":182,"column":0},"end":{"line":182,"column":38}},"182":{"start":{"line":183,"column":0},"end":{"line":183,"column":59}},"183":{"start":{"line":184,"column":0},"end":{"line":184,"column":42}},"184":{"start":{"line":185,"column":0},"end":{"line":185,"column":6}},"185":{"start":{"line":186,"column":0},"end":{"line":186,"column":42}},"186":{"start":{"line":187,"column":0},"end":{"line":187,"column":67}},"187":{"start":{"line":188,"column":0},"end":{"line":188,"column":42}},"188":{"start":{"line":189,"column":0},"end":{"line":189,"column":77}},"189":{"start":{"line":190,"column":0},"end":{"line":190,"column":41}},"190":{"start":{"line":191,"column":0},"end":{"line":191,"column":60}},"191":{"start":{"line":192,"column":0},"end":{"line":192,"column":5}},"192":{"start":{"line":193,"column":0},"end":{"line":193,"column":4}},"194":{"start":{"line":195,"column":0},"end":{"line":195,"column":75}},"195":{"start":{"line":196,"column":0},"end":{"line":196,"column":53}},"196":{"start":{"line":197,"column":0},"end":{"line":197,"column":50}},"197":{"start":{"line":198,"column":0},"end":{"line":198,"column":3}},"198":{"start":{"line":199,"column":0},"end":{"line":199,"column":3}},"200":{"start":{"line":201,"column":0},"end":{"line":201,"column":9}},"201":{"start":{"line":202,"column":0},"end":{"line":202,"column":12}},"202":{"start":{"line":203,"column":0},"end":{"line":203,"column":7}},"203":{"start":{"line":204,"column":0},"end":{"line":204,"column":8}},"204":{"start":{"line":205,"column":0},"end":{"line":205,"column":9}},"205":{"start":{"line":206,"column":0},"end":{"line":206,"column":10}},"206":{"start":{"line":207,"column":0},"end":{"line":207,"column":3}},"207":{"start":{"line":208,"column":0},"end":{"line":208,"column":1}},"209":{"start":{"line":210,"column":0},"end":{"line":210,"column":38}},"212":{"start":{"line":213,"column":0},"end":{"line":213,"column":12}}},"s":{"0":0,"1":0,"2":0,"3":0,"4":0,"22":0,"23":0,"24":0,"25":0,"26":0,"27":0,"28":0,"31":0,"32":0,"33":0,"34":0,"35":0,"37":0,"38":0,"40":0,"41":0,"42":0,"43":0,"44":0,"45":0,"46":0,"47":0,"48":0,"49":0,"51":0,"52":0,"53":0,"54":0,"55":0,"57":0,"58":0,"59":0,"61":0,"62":0,"63":0,"64":0,"65":0,"66":0,"67":0,"68":0,"70":0,"71":0,"74":0,"75":0,"76":0,"77":0,"79":0,"80":0,"81":0,"82":0,"83":0,"84":0,"86":0,"87":0,"88":0,"89":0,"90":0,"91":0,"92":0,"93":0,"94":0,"95":0,"96":0,"97":0,"98":0,"99":0,"100":0,"101":0,"102":0,"103":0,"104":0,"105":0,"106":0,"107":0,"109":0,"110":0,"112":0,"113":0,"115":0,"116":0,"119":0,"120":0,"121":0,"122":0,"123":0,"124":0,"125":0,"126":0,"127":0,"128":0,"130":0,"136":0,"137":0,"138":0,"139":0,"142":0,"143":0,"144":0,"146":0,"147":0,"148":0,"149":0,"151":0,"152":0,"153":0,"154":0,"157":0,"159":0,"160":0,"166":0,"167":0,"168":0,"169":0,"170":0,"171":0,"173":0,"175":0,"176":0,"177":0,"178":0,"179":0,"180":0,"181":0,"182":0,"183":0,"184":0,"185":0,"186":0,"187":0,"188":0,"189":0,"190":0,"191":0,"192":0,"194":0,"195":0,"196":0,"197":0,"198":0,"200":0,"201":0,"202":0,"203":0,"204":0,"205":0,"206":0,"207":0,"209":0,"212":0},"branchMap":{"0":{"type":"branch","line":1,"loc":{"start":{"line":1,"column":5919},"end":{"line":213,"column":12}},"locations":[{"start":{"line":1,"column":5919},"end":{"line":213,"column":12}}]}},"b":{"0":[0]},"fnMap":{"0":{"name":"(empty-report)","decl":{"start":{"line":1,"column":5919},"end":{"line":213,"column":12}},"loc":{"start":{"line":1,"column":5919},"end":{"line":213,"column":12}},"line":1}},"f":{"0":0}}


Stevefoale path here. I feel like github actions should generate these rather than keeping them in the repo.

cmccully · 2026-02-19T19:46:48Z

frontend/coverage/index.html

@@ -0,0 +1,146 @@
+


Empty line?

cmccully · 2026-02-19T19:46:57Z

frontend/coverage/index.html

+                <span class='fraction'>40/43</span>
+            </div>
+
+


Whitespace.

cmccully · 2026-02-19T19:47:05Z

frontend/coverage/index.html

+        <script src="block-navigation.js"></script>
+    </body>
+</html>
+


cmccully · 2026-02-19T19:47:34Z

frontend/coverage/prettify.css

@@ -0,0 +1 @@
+.pln{color:#000}@media screen{.str{color:#080}.kwd{color:#008}.com{color:#800}.typ{color:#606}.lit{color:#066}.pun,.opn,.clo{color:#660}.tag{color:#008}.atn{color:#606}.atv{color:#080}.dec,.var{color:#606}.fun{color:red}}@media print,projection{.str{color:#060}.kwd{color:#006;font-weight:bold}.com{color:#600;font-style:italic}.typ{color:#404;font-weight:bold}.lit{color:#044}.pun,.opn,.clo{color:#440}.tag{color:#006;font-weight:bold}.atn{color:#404}.atv{color:#060}}pre.prettyprint{padding:2px;border:1px solid #888}ol.linenums{margin-top:0;margin-bottom:0}li.L0,li.L1,li.L2,li.L3,li.L5,li.L6,li.L7,li.L8{list-style-type:none}li.L1,li.L3,li.L5,li.L7,li.L9{background:#eee}


Are these files loaded from somewhere else? Could we just reference the url?

cmccully · 2026-02-19T19:50:06Z

frontend/docs/component-documentation-standards.md

@@ -0,0 +1,358 @@
+# Component Documentation Standards


Where are the docs hosted? Readthedocs?

cmccully · 2026-02-19T19:57:48Z

frontend/src/lib/components/ui/Button.svelte

@@ -0,0 +1,153 @@
+<script lang="ts">


Are we not using a standard component library, e.g. bootstrap? I'm concerned that if we aren't, this is going to add to a lot of maintenance overhead.

moira-andrews · 2026-02-19T23:08:25Z

Made several issues about some front end problems, see #98, #99, #100, #101, and #102

- Remove hardcoded DB credentials from CI workflows; use env vars - Replace sticky-pull-request-comment with GitHub step summary + artifact upload for frontend coverage reporting; add lcov reporter - Wire coverage calculator form params end-to-end from CoverageCalculatorTab through to the API; add missing spec_range_low/high type fields - Track hidden instrument colours across time filter updates via OverlayManager.setHiddenInstruments() - Add named header slot to Card component - Fix alert list count to show grouped events, not raw records - Increase time slider precision from 1dp to 3dp - Switch renormalize skymap to direct fetch endpoint

sfoale added 30 commits June 17, 2025 12:06

Initial steps for svelte front end. Work in progress.

7fa0df5

Update readme

a00851a

Adding visualisation. Work in progress.

8d28223

Merge fastapi branch.

82dee5e

Basic aladin visualisation implementation complete.

Add missing files

d428471

Default to unpaginated list for query_alerts.

dc154b9

No authorisation required for alert query.

d91a5ab

Make visualization page more modular.

62df90a

Add reporting instruments page.

2072d6c

Address linting issues.

Refactor extracting reusable ui components

d601521

Extend query alerts endpoint to the instrument id page.

f54cce6

Adding footprint visualization to the instrument page.

46cc1c8

Refactoring to extract common functionality.

614a74b

Refactor: extarct astro calculations.

f44e754

Refactor: add data loader service.

287a356

Refactor: extract AlertTypeManager.

369c77e

Refactoring: add VisualizationDataManager

fe6af1e

Refactoring to extract reusable components.

86d8c90

Add search pointings page. More visualization tweaks. Signed-off-by: Steve Foale <sfoale@lco.global>

Added functionality for pointings page.

087a5a1

Visualization improvements.

Get front page image carousel working.

4c289e3

Attempting to get visualization centring correct.

Fix visualization centering.

1c09ced

Fix time slider on visualisation page.

ad44d27

Refactor the api into individual services and types.

Add instruments query page

ae719aa

Refactor alerts page using service components

ae50664

Refactored alerts select page extracting components.

83ee64d

Fix alert page event explorer summary tab.

3de7ab1

Fix linting issues and formatting.

8e306b7

Fix unused variables, missing keys errors etc.

094f688

Fix form validation and empty object types

c233a60

Implement JWT authentication and update frontend.

9303769