fix(ci): target selected Google Play track - #191
Merged
Conversation
sjungwon03-ai
approved these changes
Jul 31, 2026
sjungwon03-ai
left a comment
Member
There was a problem hiding this comment.
This change correctly switches the Google Play upload action parameter from the incorrect tracks (plural) to the proper track (singular) input for r0adkll/upload-google-play, and removes the unsupported changesNotSentForReview flag. The fix aligns with the action's documented inputs and the PR title. No blockers identified.
Inline notes on the diff:
- Line ~91:
track: ${{ inputs.track }}— correct parameter name. - Removed
changesNotSentForReview: true— not a valid input for this action version.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Corrects the Google Play upload action configuration so dispatching with
internaltargets the selected track rather than the action default. RemoveschangesNotSentForReviewbecause this Play Console app uses automatic review submission.Closes #190
Validation
npm run typecheck(CI)npm test(CI)npm run build(CI)git diff --checkpassed.Checklist
dev.Notes for reviewers
The earlier attempt created a Play edit but its commit was rejected, so no release was published. This correction keeps the upload on the explicitly selected
internaltrack and follows the Play Console automatic-review policy.