Skip to content

fix(ci): target selected Google Play track - #191

Merged
sjungwon03 merged 1 commit into
devfrom
fix/190-google-play-track
Jul 31, 2026
Merged

fix(ci): target selected Google Play track#191
sjungwon03 merged 1 commit into
devfrom
fix/190-google-play-track

Conversation

@sjungwon03

@sjungwon03 sjungwon03 commented Jul 31, 2026

Copy link
Copy Markdown
Member

Summary

Corrects the Google Play upload action configuration so dispatching with internal targets the selected track rather than the action default. Removes changesNotSentForReview because this Play Console app uses automatic review submission.

Closes #190

Validation

  • npm run typecheck (CI)
  • npm test (CI)
  • npm run build (CI)
  • Manual validation: workflow YAML parsed and git diff --check passed.

Checklist

  • This pull request targets dev.
  • I created or linked a GitHub issue for this change.
  • I used a Conventional Commit message.
  • I added or updated tests, or explained why tests are not applicable. (Workflow-input correction only; CI covers the repository build.)
  • I updated documentation where behavior or setup changed. (No documentation change is needed: the release guide already describes selecting the Play track at dispatch.)
  • I did not include secrets, private media, private file paths, credentials, or security exploit material.

Notes for reviewers

The earlier attempt created a Play edit but its commit was rejected, so no release was published. This correction keeps the upload on the explicitly selected internal track and follows the Play Console automatic-review policy.

@sjungwon03
sjungwon03 requested a review from sjungwon03-ai July 31, 2026 06:45
@sjungwon03 sjungwon03 added type:release Release promotion area:ci CI and developer tooling labels Jul 31, 2026
@sjungwon03 sjungwon03 self-assigned this Jul 31, 2026

@sjungwon03-ai sjungwon03-ai left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change correctly switches the Google Play upload action parameter from the incorrect tracks (plural) to the proper track (singular) input for r0adkll/upload-google-play, and removes the unsupported changesNotSentForReview flag. The fix aligns with the action's documented inputs and the PR title. No blockers identified.

Inline notes on the diff:

  • Line ~91: track: ${{ inputs.track }} — correct parameter name.
  • Removed changesNotSentForReview: true — not a valid input for this action version.

@sjungwon03-ai sjungwon03-ai added the review:approved Latest-head review approved label Jul 31, 2026
@sjungwon03
sjungwon03 merged commit 3373337 into dev Jul 31, 2026
1 check passed
@sjungwon03
sjungwon03 deleted the fix/190-google-play-track branch July 31, 2026 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:ci CI and developer tooling review:approved Latest-head review approved type:release Release promotion

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: target the selected Google Play track in store uploads

2 participants