feat(rst): add component capability registry#289
Merged
Conversation
swartzn
force-pushed
the
swartzn/feat/add-capability-registry
branch
3 times, most recently
from
55cbdc8 to
a53110f
Compare
iamjoemccormick
requested changes
Jan 30, 2026
Member
iamjoemccormick
left a comment
iamjoemccormick
left a comment
There was a problem hiding this comment.
Let me know if it'd be easier to hop on a call and discuss any of my feedback! In particular some of my suggestions around introducing a CachedComponentRegistry.
iamjoemccormick
requested changes
Feb 9, 2026
swartzn
force-pushed
the
swartzn/feat/add-capability-registry
branch
from
ba31a10 to
81c87ed
Compare
iamjoemccormick
previously approved these changes
Feb 10, 2026
iamjoemccormick
previously approved these changes
Feb 10, 2026
Add registry package to support component capabiltiies and build info. - add ComponentRegistry type to encapsulate component capabilities and build info. - add CachedComponentRegistry to support cached registries for individual components.
Add GetCapabilities to remote/sync servers with build info and start time. Validate capabilities before remote connects to sync nodes.
Add process-wide cached registry accessor with optional lazy init for BeeRemote.
swartzn
force-pushed
the
swartzn/feat/add-capability-registry
branch
from
b2e4035 to
0f88694
Compare
Contributor
Author
|
@iamjoemccormick I made two more changes that are clearly seen if you look at the diff, https://github.com/ThinkParQ/beegfs-go/compare/b2e40358a6324248d79269dee86bcb1dd9b436a2..0f886948f7cf2606e55a8ecf573649ea45703874. Changes:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires ThinkParQ/protobuf#66
What does this PR do / why do we need it?
Required for all PRs.
Add global component registry for build-info/features with support helpers.
Expose GetCapabilities on remote and sync servers.
Block sync connections to remote when required features are missing.
Gate remote push filters behind the new filter-files feature flag.
Related Issue(s)
Required when applicable.
Where should the reviewer(s) start reviewing this?
Only required for larger PRs when this may not be immediately obvious.
Are there any specific topics we should discuss before merging?
Not required.
What are the next steps after this PR?
Not required.
Checklist before merging:
Required for all PRs.
When creating a PR these are items to keep in mind that cannot be checked by GitHub actions:
For more details refer to the Go coding standards and the pull request process.